[v5,11/12] blk-mq: clarify dispatch may not be drained/blocked by stopping queue

Commit Message

Ming Lei June 6, 2017, 3:22 p.m. UTC

BLK_MQ_S_STOPPED may not be observed in other concurrent I/O paths,
we can't guarantee that dispatching won't happen after returning
from the APIs of stopping queue.

So clarify the fact and avoid potential misuse.

Signed-off-by: Ming Lei <[e-mail]>
---
 block/blk-mq.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Bart Van Assche June 6, 2017, 4:07 p.m. UTC | #1

On Tue, 2017-06-06 at 23:22 +0800, Ming Lei wrote:
> BLK_MQ_S_STOPPED may not be observed in other concurrent I/O paths,
> we can't guarantee that dispatching won't happen after returning
> from the APIs of stopping queue.
> 
> So clarify the fact and avoid potential misuse.

Reviewed-by: Bart Van Assche <[e-mail]>

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 4eb849bf1d85..7b584bf7d310 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1186,6 +1186,15 @@  static void __blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx, bool sync)
 	set_bit(BLK_MQ_S_STOPPED, &hctx->state);
 }
 
+/*
+ * This function is often used for pausing .queue_rq() by driver when
+ * there isn't enough resource or some conditions aren't satisfied, and
+ * BLK_MQ_RQ_QUEUE_BUSY is usually returned.
+ *
+ * We do not guarantee that dispatch can be drained or blocked
+ * after blk_mq_stop_hw_queue() returns. Please use
+ * blk_mq_quiesce_queue() for that requirement.
+ */
 void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx)
 {
 	__blk_mq_stop_hw_queue(hctx, false);
@@ -1201,6 +1210,15 @@  static void __blk_mq_stop_hw_queues(struct request_queue *q, bool sync)
 		__blk_mq_stop_hw_queue(hctx, sync);
 }
 
+/*
+ * This function is often used for pausing .queue_rq() by driver when
+ * there isn't enough resource or some conditions aren't satisfied, and
+ * BLK_MQ_RQ_QUEUE_BUSY is usually returned.
+ *
+ * We do not guarantee that dispatch can be drained or blocked
+ * after blk_mq_stop_hw_queues() returns. Please use
+ * blk_mq_quiesce_queue() for that requirement.
+ */
 void blk_mq_stop_hw_queues(struct request_queue *q)
 {
 	__blk_mq_stop_hw_queues(q, false);