diff mbox

blk-tag: not touch rq->internal_tag

Message ID 20170616080655.23838-1-ming.lei@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ming Lei June 16, 2017, 8:06 a.m. UTC 
rq->internal_tag is introduced only for blk-mq, so
it isn't necessary to touch this variable in blk-tag.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 block/blk-tag.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Christoph Hellwig June 16, 2017, 8:24 a.m. UTC | #1 
On Fri, Jun 16, 2017 at 04:06:55PM +0800, Ming Lei wrote:
> rq->internal_tag is introduced only for blk-mq, so
> it isn't necessary to touch this variable in blk-tag.
> 
> Signed-off-by: Ming Lei <ming.lei@redhat.com>

It's not harmful either, is it?
Ming Lei June 16, 2017, 12:22 p.m. UTC | #2 
On Fri, Jun 16, 2017 at 01:24:09AM -0700, Christoph Hellwig wrote:
> On Fri, Jun 16, 2017 at 04:06:55PM +0800, Ming Lei wrote:
> > rq->internal_tag is introduced only for blk-mq, so
> > it isn't necessary to touch this variable in blk-tag.
> > 
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> 
> It's not harmful either, is it?

Yes, it is not harmful, also not necessary.

Thanks,
Ming
diff mbox

Patch

diff --git a/block/blk-tag.c b/block/blk-tag.c
index 07cc329fa4b0..bae1decb6ec3 100644
--- a/block/blk-tag.c
+++ b/block/blk-tag.c
@@ -272,7 +272,6 @@  void blk_queue_end_tag(struct request_queue *q, struct request *rq)
 	list_del_init(&rq->queuelist);
 	rq->rq_flags &= ~RQF_QUEUED;
 	rq->tag = -1;
-	rq->internal_tag = -1;
 
 	if (unlikely(bqt->tag_index[tag] == NULL))
 		printk(KERN_ERR "%s: tag %d is missing\n",