diff mbox

[5/5] skd: Change default interrupt mode to MSI-X

Message ID 20170823175633.12680-6-bart.vanassche@wdc.com (mailing list archive)
State New, archived
Headers show

Commit Message

Bart Van Assche Aug. 23, 2017, 5:56 p.m. UTC
Since MSI support on some motherboards is unreliable, change the
default interrupt mode from MSI to MSI-X. This patch avoids that
the following message appears sporadially in the kernel logs of
my test setup:

do_IRQ: 3.193 No irq handler for vector

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
---
 drivers/block/skd_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Aug. 23, 2017, 6:06 p.m. UTC | #1
On Wed, Aug 23, 2017 at 10:56:33AM -0700, Bart Van Assche wrote:
> Since MSI support on some motherboards is unreliable, change the
> default interrupt mode from MSI to MSI-X. This patch avoids that
> the following message appears sporadially in the kernel logs of
> my test setup:

It might be worth noting that the driver still supports MSI
and INTX interrupts in this mode, which makes it match what most
other drivers do.

Signed-off-by: Christoph Hellwig <hch@lst.de>
diff mbox

Patch

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index ff288f1a5dec..577618c57975 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -310,7 +310,7 @@  static inline void skd_reg_write64(struct skd_device *skdev, u64 val,
 }
 
 
-#define SKD_IRQ_DEFAULT SKD_IRQ_MSI
+#define SKD_IRQ_DEFAULT SKD_IRQ_MSIX
 static int skd_isr_type = SKD_IRQ_DEFAULT;
 
 module_param(skd_isr_type, int, 0444);