From patchwork Fri Nov 10 10:01:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10052747 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9196A6035D for ; Fri, 10 Nov 2017 10:02:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D8CB2B24A for ; Fri, 10 Nov 2017 10:02:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 727AE2B257; Fri, 10 Nov 2017 10:02:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94D692B252 for ; Fri, 10 Nov 2017 10:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdKJKCE (ORCPT ); Fri, 10 Nov 2017 05:02:04 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:44007 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbdKJKCB (ORCPT ); Fri, 10 Nov 2017 05:02:01 -0500 Received: by mail-lf0-f65.google.com with SMTP id o66so2200205lfg.0 for ; Fri, 10 Nov 2017 02:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E7YlvG7DlQwP+vdm50/EiojcBTJPzzEzXt9DrRyxwrA=; b=gVcIEbw500BzGvgH1ZgT/rYq5OXOcCP37tX4dP0+Aahz04RiPRW1EoycQhX8ItXTsb Z4xYwf2XhYbWhU5kJVFPKiFBW/lHchf6jFeojEyIBzIytDpFXekgBzVVXpb1rgBawU2W lYy8C9Eew/vs+e9knI+aIlR9KqwP0Ds56c84s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E7YlvG7DlQwP+vdm50/EiojcBTJPzzEzXt9DrRyxwrA=; b=jCNhJqmO+O3gfMFuQu+7cGD9UHdTfG1TprvDUwoJCr8Da5xwrI8Bvi1MZ+61FJuWg3 U80kkZ4WpEO28XZ02hk8nBHmuTckuK15IxlrZXO0ki5gkwJFz8zw21QhzLfOTfE0HUET HcM2G0IEzkuw1sbTX/ZuungF2VLOCVnaB3bkSdkLG59wFHd6PJ1JiRdT06DQCpCcD8YN x73wLfUgTXa6uDhJ+nH3NcJJczKEkxYjHC+J3F5Q56zE7bAX5RfcKRATmv8bCtjM9c9f k6HRqWpqZlAFVov38DwQjxaqUKThZAddobSPfGr+o+h1KYyP/a0hBaaLNuOQHxxReSiz 8pJg== X-Gm-Message-State: AJaThX5Rd8Xk+Rgoc91CnVOi4NPsRwPlUovkCPkf2AZpJ59R48bfab1J VPlSz8UuT1vIiUr4+WV9OW6ZppfLQnY= X-Google-Smtp-Source: ABhQp+RI68J6reX7tBCVhsYpihN0fPj+g2WV05NAeQcYLXVRogtUiMGe4V6kL1yqsO5aG26kDWwkTA== X-Received: by 10.46.89.147 with SMTP id g19mr1398584ljf.26.1510308120399; Fri, 10 Nov 2017 02:02:00 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id n36sm310843lfi.78.2017.11.10.02.01.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 10 Nov 2017 02:01:59 -0800 (PST) From: Linus Walleij To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Paolo Valente , Avri Altman , Adrian Hunter , Linus Walleij Subject: [PATCH 05/12] mmc: core: do away with is_new_req Date: Fri, 10 Nov 2017 11:01:36 +0100 Message-Id: <20171110100143.12256-6-linus.walleij@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171110100143.12256-1-linus.walleij@linaro.org> References: <20171110100143.12256-1-linus.walleij@linaro.org> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The host context member "is_new_req" is only assigned values, never checked. Delete it. Signed-off-by: Linus Walleij --- ChangeLog v1->v5: - Rebasing on the "next" branch in the MMC tree. --- drivers/mmc/core/core.c | 1 - drivers/mmc/core/queue.c | 5 ----- include/linux/mmc/host.h | 2 -- 3 files changed, 8 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 15a664d3c199..b1a5059f6cd1 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -3007,7 +3007,6 @@ void mmc_unregister_pm_notifier(struct mmc_host *host) */ void mmc_init_context_info(struct mmc_host *host) { - host->context_info.is_new_req = false; host->context_info.is_waiting_last_req = false; } diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index c46be4402803..4a0752ef6154 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -55,7 +55,6 @@ static int mmc_queue_thread(void *d) req = blk_fetch_request(q); mq->asleep = false; cntx->is_waiting_last_req = false; - cntx->is_new_req = false; if (!req) { /* * Dispatch queue is empty so set flags for @@ -109,10 +108,6 @@ static void mmc_request_fn(struct request_queue *q) cntx = &mq->card->host->context_info; - if (cntx->is_waiting_last_req) { - cntx->is_new_req = true; - } - if (mq->asleep) wake_up_process(mq->thread); } diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index d43d26562fae..36af19990683 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -241,11 +241,9 @@ struct mmc_slot { /** * mmc_context_info - synchronization details for mmc context - * @is_new_req wake up reason was new request * @is_waiting_last_req mmc context waiting for single running request */ struct mmc_context_info { - bool is_new_req; bool is_waiting_last_req; };