From patchwork Mon Feb 26 19:45:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heiner Litz X-Patchwork-Id: 10243125 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1780160208 for ; Mon, 26 Feb 2018 19:46:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 04ED11FF62 for ; Mon, 26 Feb 2018 19:46:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED5062A25F; Mon, 26 Feb 2018 19:46:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D2F71FF62 for ; Mon, 26 Feb 2018 19:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbeBZTqH (ORCPT ); Mon, 26 Feb 2018 14:46:07 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:40432 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbeBZTqH (ORCPT ); Mon, 26 Feb 2018 14:46:07 -0500 Received: by mail-pf0-f193.google.com with SMTP id m5so6941002pff.7 for ; Mon, 26 Feb 2018 11:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucsc.edu; s=ucsc-google; h=from:to:cc:subject:date:message-id; bh=qOuDWkXQ4+n4COkGKbkjfvHz7mQumm+SGgyLNiKEY5U=; b=aXKBgacvJbP75SxIrYbIg8MECFilnh4tilpHmHCsaY1Z7aUj1m5m7Zpy/HZvq7gtM2 8B33aX8c1BPUJ7AyvaCUa2c07Hi4rRwuQkuULBPdW9l3eob8nBxjYjg4ofMLDx5fkB3k somblYoaC91ayce5EZtq/yyLIRdtA55anvejs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qOuDWkXQ4+n4COkGKbkjfvHz7mQumm+SGgyLNiKEY5U=; b=AtelAHCugpiidi3J2AVg8D3xw2+7aG/N/wDHa/0IJaAstKjnDSZSrBxedyCS/zbeei 1UmgZ0Bjmnm63vTbi/mzD6FBPVAWOSS18Pt32dXOKgmndfcrmtjEuchpJe2BE1H9YDyC 5qa8Y+tyEfZ0M8xzV+HPC42qVrggp+z7Zjjq8c7eE6aRmDm1YfLlymxPq70pM7lX3/H8 bhKId2dqlYdQFEeiVsCJTQHh6Vm3gey7KYtC4Zf6PQ1P8DK+uhnMEEA6EFfMrHjwLZW1 /tl8Ad5zqSZw331SWvyTzuEgBQ7L618+dXafoJW3BQqDinn5PqWuwX1sSPYhMNWhM/V4 ZTIA== X-Gm-Message-State: APf1xPCg41ibCjgiMC988tLo+GoI0ALRZDTPfxlhew/dfUtgHsxqih0S 7CXGPhOOMVfAyIjoKJerWWDzLUQU X-Google-Smtp-Source: AH8x224zJrkyUv7fhqLxddd2qlyqX9KEtDkyuv7A+7nppjl+T1z4Z24oJfeR25DOSt0QYvnpsYhQ1Q== X-Received: by 10.101.82.12 with SMTP id o12mr9203977pgp.126.1519674366166; Mon, 26 Feb 2018 11:46:06 -0800 (PST) Received: from schroedinger.soe.ucsc.edu (schroedinger.soe.ucsc.edu. [128.114.59.16]) by smtp.gmail.com with ESMTPSA id a6sm21727260pfi.22.2018.02.26.11.46.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2018 11:46:05 -0800 (PST) From: Heiner Litz To: linux-block@vger.kernel.org Cc: javier@cnexlabs.com, mb@lightnvm.io, Heiner Litz Subject: [PATCH] lightnvm: Avoid validation of default op value Avoid validation of default op value, if default value is given. In preparation of using the rsvd field of the extended config for additional paramters while using default op. Date: Mon, 26 Feb 2018 11:45:57 -0800 Message-Id: <20180226194557.12226-1-hlitz@ucsc.edu> X-Mailer: git-send-email 2.14.1 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: 38401d231de65 ("lightnvm: set target over-provision on create ioctl") Signed-off-by: Heiner Litz Reviewed-by: Javier González --- drivers/lightnvm/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index dcc9e621e651..4e6095e2af06 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -304,10 +304,9 @@ static int __nvm_config_extended(struct nvm_dev *dev, } /* op not set falls into target's default */ - if (e->op == 0xFFFF) + if (e->op == 0xFFFF) { e->op = NVM_TARGET_DEFAULT_OP; - - if (e->op < NVM_TARGET_MIN_OP || + } else if (e->op < NVM_TARGET_MIN_OP || e->op > NVM_TARGET_MAX_OP) { pr_err("nvm: invalid over provisioning value\n"); return -EINVAL;