| Message ID | 20180315150814.9412-10-bart.vanassche@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15/03/2018 11:08 PM, Bart Van Assche wrote: > A bio_set_op_attrs() call a little further down overwrites bio->bi_opf. > That means that the bio->bi_opf assignment is redundant. Hence remove it. > See also commit ad0d9e76a412 ("bcache: use bio op accessors"). > > Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> > Cc: Mike Christie <mchristi@redhat.com> > Cc: Hannes Reinecke <hare@suse.com> Reviewed-by: Coly Li <colyli@suse.de> Thanks. Coly Li > --- > drivers/md/bcache/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 87c1f853bbb3..d19a44cd1fd7 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -353,7 +353,6 @@ static void uuid_io(struct cache_set *c, int op, unsigned long op_flags, > for (i = 0; i < KEY_PTRS(k); i++) { > struct bio *bio = bch_bbio_alloc(c); > > - bio->bi_opf = REQ_SYNC | REQ_META | op_flags; > bio->bi_iter.bi_size = KEY_SIZE(k) << 9; > > bio->bi_end_io = uuid_endio; >
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 87c1f853bbb3..d19a44cd1fd7 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -353,7 +353,6 @@ static void uuid_io(struct cache_set *c, int op, unsigned long op_flags, for (i = 0; i < KEY_PTRS(k); i++) { struct bio *bio = bch_bbio_alloc(c); - bio->bi_opf = REQ_SYNC | REQ_META | op_flags; bio->bi_iter.bi_size = KEY_SIZE(k) << 9; bio->bi_end_io = uuid_endio;
A bio_set_op_attrs() call a little further down overwrites bio->bi_opf. That means that the bio->bi_opf assignment is redundant. Hence remove it. See also commit ad0d9e76a412 ("bcache: use bio op accessors"). Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Mike Christie <mchristi@redhat.com> Cc: Hannes Reinecke <hare@suse.com> --- drivers/md/bcache/super.c | 1 - 1 file changed, 1 deletion(-)