From patchwork Thu Mar 15 15:08:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10284715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D6F46061F for ; Thu, 15 Mar 2018 15:08:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0182728A57 for ; Thu, 15 Mar 2018 15:08:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E99EE28B1C; Thu, 15 Mar 2018 15:08:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7467028A57 for ; Thu, 15 Mar 2018 15:08:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbeCOPIb (ORCPT ); Thu, 15 Mar 2018 11:08:31 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:23307 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748AbeCOPIa (ORCPT ); Thu, 15 Mar 2018 11:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1521127618; x=1552663618; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=51Q12uS/qFB//6Uyz92XThY7H7Tsw7RAGhCmzoIkEnA=; b=R5QGTnMsKesZvYf5CSrgV04vpFQf42sKV8jCODarBOtsYfqu0IB8xAyo p6J91dKM6VWypYdWExwYot674zxjUjmTam1ZuvU//+FiJ6MLLig1IwCyU WWG2o3qU7kp+EazK7nCMfmGTqNLDXgKZPx0YVt7ojMzL9Wz1hG1awki3B odMWE6iWBmJSslAhGZjLuVYqTo6sn/uQ4dhQT2FkRnNmyFBJ3HLdqm6hN eq+CfwHR0fdKLReh7FTenDbpGTbzDVhVCAA84BUJOnA/Jkay6M4LToSLk hAHkI7Zqtq3+dJ++zihNRBY92mhMjH2aCxWVbWGGBHFOl2ftRx/WmQ4uu g==; X-IronPort-AV: E=Sophos;i="5.47,471,1515427200"; d="scan'208";a="170233269" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Mar 2018 23:26:37 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP; 15 Mar 2018 08:01:14 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com (HELO thinkpad-bart.int.fusionio.com) ([10.11.171.236]) by uls-op-cesaip02.wdc.com with ESMTP; 15 Mar 2018 08:08:17 -0700 From: Bart Van Assche To: Michael Lyle , Kent Overstreet , Coly Li Cc: linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche , Mike Christie , Hannes Reinecke Subject: [PATCH 09/16] bcache: Remove a redundant assignment Date: Thu, 15 Mar 2018 08:08:07 -0700 Message-Id: <20180315150814.9412-10-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180315150814.9412-1-bart.vanassche@wdc.com> References: <20180315150814.9412-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A bio_set_op_attrs() call a little further down overwrites bio->bi_opf. That means that the bio->bi_opf assignment is redundant. Hence remove it. See also commit ad0d9e76a412 ("bcache: use bio op accessors"). Signed-off-by: Bart Van Assche Cc: Mike Christie Cc: Hannes Reinecke Reviewed-by: Coly Li --- drivers/md/bcache/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 87c1f853bbb3..d19a44cd1fd7 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -353,7 +353,6 @@ static void uuid_io(struct cache_set *c, int op, unsigned long op_flags, for (i = 0; i < KEY_PTRS(k); i++) { struct bio *bio = bch_bbio_alloc(c); - bio->bi_opf = REQ_SYNC | REQ_META | op_flags; bio->bi_iter.bi_size = KEY_SIZE(k) << 9; bio->bi_end_io = uuid_endio;