From patchwork Thu Mar 29 22:04:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matias Bjorling X-Patchwork-Id: 10316593 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 81CAE60353 for ; Thu, 29 Mar 2018 22:15:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69D4A2A4B9 for ; Thu, 29 Mar 2018 22:15:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5ECA72A536; Thu, 29 Mar 2018 22:15:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D26452A4B9 for ; Thu, 29 Mar 2018 22:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172AbeC2WHF (ORCPT ); Thu, 29 Mar 2018 18:07:05 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:46351 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206AbeC2WHB (ORCPT ); Thu, 29 Mar 2018 18:07:01 -0400 Received: by mail-lf0-f68.google.com with SMTP id j68-v6so10301888lfg.13 for ; Thu, 29 Mar 2018 15:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZRr1DZVyL3KOF6ACWf9iVwIO9QjRjmzxucRU3/YeZI0=; b=OyqyUQXpNDYCgEyktzNAtFRwgDjjO5RZnONVX07eBzS4M3GCDSgotdWwxUGQh+hU5d wA6XX+JCVLxNuh3khJwmtl+XTRPgmm+8n9USbm0nHPfjAeNI7eHbC4c49IHaokURHUtS nQO19qUnCncf75BKSDh+2Uv9/VGvJ/3MXoEEIHozeg1TBrIVgxHbFOGDV6R2mHrpZ7+K sXrvcebgJK8TcSyA3DdcdnwNzhqZx3LFwUoPQit+voIxWTyVEPfjkb+iRUpPXMtuzI8H QxDJpXBJSVbqQrlNyKgfItlI2tCV682cdOkH0UKhN1jemNJfRVwe70S9XrkUps5kKNoq Amuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZRr1DZVyL3KOF6ACWf9iVwIO9QjRjmzxucRU3/YeZI0=; b=g7dIlHmp5BRchfUwZGA2Bt568RdFkp0gLW29EJmPlNCmx+YrNhbIHiRg6lUrdFOeHR ZJ2LfWIBOicTdG6g7Tc2SDeQ51z35DrCQ5BEcnYPeNcORpRA20MEFURgvTECjHNf90JB 7przr/RNl4GI0HTW6plMIiDGQIZcJRJ35DQ6boXIRKPZiFi2gdj3d7rmgE85RqX2JZKk OX8B3yipBJjPSdWRX0CoyqCze5XudGsayCu6BIWGVLDzidjfdceJiavMb/l9sbrNxlqJ 5F8OpdvWl4fkxnTENOQPc8dl4EaJ8EQ+1ScD36vxCPipHlgdaw3rgatGIgBQoysNquiv Av4A== X-Gm-Message-State: AElRT7F+N297uNAVf3ieSOUMjYSvxvVdiYiwk2BsJCiihvF6V1ysF6QU XiXTtT95a0XOQ6FQI3/w7u+15g== X-Google-Smtp-Source: AIpwx49HzmhPkcUxNrKREfTyvcZdsIrd4h0KudJyrnYxFmdbN62eELlJYOfomlrFl4I05BmcnOwrNA== X-Received: by 10.46.91.21 with SMTP id p21mr6837389ljb.38.1522361215546; Thu, 29 Mar 2018 15:06:55 -0700 (PDT) Received: from Macroninja.cnexlabs.com (x1-6-a4-08-f5-18-3c-3a.cpe.webspeed.dk. [188.176.29.198]) by smtp.gmail.com with ESMTPSA id i89-v6sm1365508lfk.12.2018.03.29.15.06.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 15:06:54 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, keith.busch@intel.com, javier@cnexlabs.com, Markus Elfring , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 01/37] lightnvm/pblk-gc: Delete an error message for a failed memory allocation in pblk_gc_line_prepare_ws() Date: Fri, 30 Mar 2018 00:04:48 +0200 Message-Id: <20180329220524.30363-2-mb@lightnvm.io> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180329220524.30363-1-mb@lightnvm.io> References: <20180329220524.30363-1-mb@lightnvm.io> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-gc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index 3d899383666e..31f17d6f14ee 100644 --- a/drivers/lightnvm/pblk-gc.c +++ b/drivers/lightnvm/pblk-gc.c @@ -147,10 +147,8 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) int ret; invalid_bitmap = kmalloc(lm->sec_bitmap_len, GFP_KERNEL); - if (!invalid_bitmap) { - pr_err("pblk: could not allocate GC invalid bitmap\n"); + if (!invalid_bitmap) goto fail_free_ws; - } emeta_buf = pblk_malloc(lm->emeta_len[0], l_mg->emeta_alloc_type, GFP_KERNEL);