From patchwork Tue May 8 14:05:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Weiner X-Patchwork-Id: 10386219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A52F8602C2 for ; Tue, 8 May 2018 14:03:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F50E20174 for ; Tue, 8 May 2018 14:03:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 811A428676; Tue, 8 May 2018 14:03:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66E0C20174 for ; Tue, 8 May 2018 14:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932209AbeEHOD4 (ORCPT ); Tue, 8 May 2018 10:03:56 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:49796 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079AbeEHODz (ORCPT ); Tue, 8 May 2018 10:03:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oyJQmBpzqh5ewuafcNHrhg6XsQdnMkilUl342uCnO24=; b=tZIJudIyDaghcK0DG591UAqXrv C2PJF1TDAS6RfcfpmAdFlky+bJO9rV4TAdAON/surU5tZ144pcZ11zsfpRtwFeX3RkoNYCoczsdHb 95RVO/GNW8K9/+Hn7svn52/vgBh8Epj6mX1RPoDgbph/z7xyg3pR2nHcK82XFtFU3EPs=; Date: Tue, 8 May 2018 10:05:33 -0400 From: Johannes Weiner To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, cgroups@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , Tejun Heo , Balbir Singh , Mike Galbraith , Oliver Yang , Shakeel Butt , xxx xxx , Taras Kondratiuk , Daniel Walker , Vinayak Menon , Ruslan Ruslichenko , kernel-team@fb.com Subject: Re: [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO Message-ID: <20180508140533.GA2900@cmpxchg.org> References: <20180507210135.1823-7-hannes@cmpxchg.org> <201805080952.2yQWmzU2%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201805080952.2yQWmzU2%fengguang.wu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 08, 2018 at 11:04:09AM +0800, kbuild test robot wrote: > 118 #else /* CONFIG_PSI */ > 119 static inline void psi_enqueue(struct task_struct *p, u64 now) > 120 { > 121 } > 122 static inline void psi_dequeue(struct task_struct *p, u64 now) > 123 { > 124 } > 125 static inline void psi_ttwu_dequeue(struct task_struct *p) {} > > 126 { > 127 } Stupid last-minute cleanup reshuffling. v2 will have: diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h index cb4a68bcf37a..ff6256b3d216 100644 --- a/kernel/sched/stats.h +++ b/kernel/sched/stats.h @@ -122,7 +122,7 @@ static inline void psi_enqueue(struct task_struct *p, u64 now) static inline void psi_dequeue(struct task_struct *p, u64 now) { } -static inline void psi_ttwu_dequeue(struct task_struct *p) {} +static inline void psi_ttwu_dequeue(struct task_struct *p) { } #endif /* CONFIG_PSI */