From patchwork Tue May 29 21:17:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10437161 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F2961601E9 for ; Tue, 29 May 2018 21:21:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4D26287D2 for ; Tue, 29 May 2018 21:21:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D93FE28975; Tue, 29 May 2018 21:21:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D8DA287D2 for ; Tue, 29 May 2018 21:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966689AbeE2VVn (ORCPT ); Tue, 29 May 2018 17:21:43 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:34865 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967007AbeE2VR3 (ORCPT ); Tue, 29 May 2018 17:17:29 -0400 Received: by mail-qk0-f195.google.com with SMTP id d130-v6so7325820qkc.2 for ; Tue, 29 May 2018 14:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PK9SM6Or93iN9H7VsfeL6v/TgtFB9uw6ZcSS0L5F/OA=; b=Q2eXIVJsZfqY/e3e9Z68Wc6g8uTnwGkptwm4e0Xa8K1DN2IOzcNmABsQKyCa0FUE/k +V/fRQyszCDzaDy+PlKLsJ2ac/IptAt4CTBrGPjwS2w9VKD09Wz8TMKf7B+4/4eqMDdf PvmQmJ+6eqkpN6wmey3a7KU5OpInAiTjsu6FHUHuRAFXFbjkesvgaiiGsBKjUDciQ2jq ZTxYuMS8DdWIQcSZKm42jMyFrsiruXU53jBQeFC6i8Rct7kk1Xuis6QuVCN9694UQ0ip S4R5ncFmyr0orZrPxpzdUS39A8hk7i55CoSp3T5bfqRD7buxoEcMTUQARLaqSHAHyC7M cotQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PK9SM6Or93iN9H7VsfeL6v/TgtFB9uw6ZcSS0L5F/OA=; b=cSYUj6HZ+mAjY/ASRRUw3hLcwmmJs62GWZGUSKmty0SWiMQXXVB4vZ8Wl/2hE9QZEX HrXcttAWMoAyoBa8GYwmu3igzbc9wTpYFpRGhmStRBQfipp+ZBOGwkkO8g7zDUUTGBWm +QrrMjtlJUeLUk7ZbMUo9X6i/ICeU2SaJQxTKoOin89HKTSsCMe0seqzqh82Je/roB20 z5bKSUUS9/sNYLSNFt8Aid6UlNgBnWgiRd0IALD4+f0vvz4H/is+J5s//3Dd278Prma5 dMZZ/+f4t8vAnWHgln0XOTkOX1yHauGy86cMf+jzw6X65/WCQ4ckfULk6Lgbpjku4MJf ZXow== X-Gm-Message-State: APt69E2qpDJEGncdIO4LXfKgOrpn3YKdzcEDw9NDFXdvZMcEIZJR3zZ6 /32YBTtQSDyeLOsWKYJHo365OQ== X-Google-Smtp-Source: ADUXVKLij/YbfWwoXlhTIsq3l6kEOu1tE3bFXIUvrF/sX9h2a+NB9G5T5MkxlQV53k6hqZUK29nKUw== X-Received: by 2002:a37:b943:: with SMTP id j64-v6mr76003qkf.362.1527628649081; Tue, 29 May 2018 14:17:29 -0700 (PDT) Received: from localhost (cpe-2606-A000-4381-1201-225-22FF-FEB3-E51A.dyn6.twc.com. [2606:a000:4381:1201:225:22ff:feb3:e51a]) by smtp.gmail.com with ESMTPSA id e5-v6sm22430568qkf.35.2018.05.29.14.17.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 14:17:28 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, kernel-team@fb.com, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, tj@kernel.org, linux-fsdevel@vger.kernel.org Cc: Josef Bacik Subject: [PATCH 01/13] block: add bi_blkg to the bio for cgroups Date: Tue, 29 May 2018 17:17:12 -0400 Message-Id: <20180529211724.4531-2-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180529211724.4531-1-josef@toxicpanda.com> References: <20180529211724.4531-1-josef@toxicpanda.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Josef Bacik Currently io.low uses a bi_cg_private to stash its private data for the blkg, however other blkcg policies may want to use this as well. Since we can get the private data out of the blkg, move this to bi_blkg in the bio and make it generic, then we can use bio_associate_blkg() to attach the blkg to the bio. Theoretically we could simply replace the bi_css with this since we can get to all the same information from the blkg, however you have to lookup the blkg, so for example wbc_init_bio() would have to lookup and possibly allocate the blkg for the css it was trying to attach to the bio. This could be problematic and result in us either not attaching the css at all to the bio, or falling back to the root blkcg if we are unable to allocate the corresponding blkg. So for now do this, and in the future if possible we could just replace the bi_css with bi_blkg and update the helpers to do the correct translation. Signed-off-by: Josef Bacik Acked-by: Tejun Heo --- block/bio.c | 23 +++++++++++++++++++++++ block/blk-throttle.c | 21 +++++++-------------- include/linux/bio.h | 1 + include/linux/blk_types.h | 2 +- 4 files changed, 32 insertions(+), 15 deletions(-) diff --git a/block/bio.c b/block/bio.c index 0a4df92cd689..57c4b1986e76 100644 --- a/block/bio.c +++ b/block/bio.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include "blk.h" @@ -2026,6 +2027,24 @@ int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css) } EXPORT_SYMBOL_GPL(bio_associate_blkcg); +/** + * bio_associate_blkg - associate a bio with the specified blkg + * @bio: target bio + * @blkg: the blkg to associate + * + * Associate @bio with the blkg specified by @blkg. This is the queue specific + * blkcg information associated with the @bio, a reference will be taken on the + * @blkg and will be freed when the bio is freed. + */ +int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg) +{ + if (unlikely(bio->bi_blkg)) + return -EBUSY; + blkg_get(blkg); + bio->bi_blkg = blkg; + return 0; +} + /** * bio_disassociate_task - undo bio_associate_current() * @bio: target bio @@ -2040,6 +2059,10 @@ void bio_disassociate_task(struct bio *bio) css_put(bio->bi_css); bio->bi_css = NULL; } + if (bio->bi_blkg) { + blkg_put(bio->bi_blkg); + bio->bi_blkg = NULL; + } } /** diff --git a/block/blk-throttle.c b/block/blk-throttle.c index f63d88c92c3a..5112cef3166b 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -2131,12 +2131,8 @@ static inline void throtl_update_latency_buckets(struct throtl_data *td) static void blk_throtl_assoc_bio(struct throtl_grp *tg, struct bio *bio) { #ifdef CONFIG_BLK_DEV_THROTTLING_LOW - if (bio->bi_css) { - if (bio->bi_cg_private) - blkg_put(tg_to_blkg(bio->bi_cg_private)); - bio->bi_cg_private = tg; - blkg_get(tg_to_blkg(tg)); - } + if (bio->bi_css) + bio_associate_blkg(bio, tg_to_blkg(tg)); bio_issue_init(&bio->bi_issue, bio_sectors(bio)); #endif } @@ -2284,6 +2280,7 @@ void blk_throtl_stat_add(struct request *rq, u64 time_ns) void blk_throtl_bio_endio(struct bio *bio) { + struct blkcg_gq *blkg; struct throtl_grp *tg; u64 finish_time_ns; unsigned long finish_time; @@ -2291,20 +2288,18 @@ void blk_throtl_bio_endio(struct bio *bio) unsigned long lat; int rw = bio_data_dir(bio); - tg = bio->bi_cg_private; - if (!tg) + blkg = bio->bi_blkg; + if (!blkg) return; - bio->bi_cg_private = NULL; + tg = blkg_to_tg(blkg); finish_time_ns = ktime_get_ns(); tg->last_finish_time = finish_time_ns >> 10; start_time = bio_issue_time(&bio->bi_issue) >> 10; finish_time = __bio_issue_time(finish_time_ns) >> 10; - if (!start_time || finish_time <= start_time) { - blkg_put(tg_to_blkg(tg)); + if (!start_time || finish_time <= start_time) return; - } lat = finish_time - start_time; /* this is only for bio based driver */ @@ -2333,8 +2328,6 @@ void blk_throtl_bio_endio(struct bio *bio) tg->bio_cnt /= 2; tg->bad_bio_cnt /= 2; } - - blkg_put(tg_to_blkg(tg)); } #endif diff --git a/include/linux/bio.h b/include/linux/bio.h index 98b175cc00d5..f2f3f1428e81 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -547,6 +547,7 @@ do { \ #ifdef CONFIG_BLK_CGROUP int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css); +int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg); void bio_disassociate_task(struct bio *bio); void bio_clone_blkcg_association(struct bio *dst, struct bio *src); #else /* CONFIG_BLK_CGROUP */ diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 4cb970cdcd11..ff181df8c195 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -179,8 +179,8 @@ struct bio { */ struct io_context *bi_ioc; struct cgroup_subsys_state *bi_css; + struct blkcg_gq *bi_blkg; #ifdef CONFIG_BLK_DEV_THROTTLING_LOW - void *bi_cg_private; struct bio_issue bi_issue; #endif #endif