From patchwork Tue Jun 19 20:23:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10475403 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AB6596029B for ; Tue, 19 Jun 2018 20:24:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C992286B2 for ; Tue, 19 Jun 2018 20:24:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 91A9928BE8; Tue, 19 Jun 2018 20:24:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DAA0286B2 for ; Tue, 19 Jun 2018 20:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966838AbeFSUYj (ORCPT ); Tue, 19 Jun 2018 16:24:39 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:8434 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967224AbeFSUX5 (ORCPT ); Tue, 19 Jun 2018 16:23:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1529439837; x=1560975837; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=AXdNj6gO8ukguOI8y813ncNTGnewMtV8PXGWUNWqBYc=; b=e/e+b0xM9wrpfVchS6fX5ENkXDM9+0AV5TWN7iPyzjicmw14Lvcaeu5m XCM73ybrzLULGEGiz/zrqwU1x7YT/xyw7uyQ0TIrluP2uVOML6u2/avC2 kj4HFz3m/TI3ewVZAi/Ejek88oDzrsTpyqKRpBCg9rY7VevNTouCJbIeC thwShgRRfjrSng8QMimUUOGqFApeAQwrhOmaGqIWV58DInzwbZWZ1CbCQ RiGAjc4tE/0srcuJQsnonNJYRqRKyXeYo9cPDxqYliHXvMRx++e8+fgbN 1tlX9nnGjNeB7hYhK/LTBbobm/qkwhbdkjB45UrqhOw1akUiuEae2t02k Q==; X-IronPort-AV: E=Sophos;i="5.51,244,1526313600"; d="scan'208";a="80867885" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 20 Jun 2018 04:23:56 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP; 19 Jun 2018 13:13:48 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com ([10.111.67.248]) by uls-op-cesaip02.wdc.com with ESMTP; 19 Jun 2018 13:23:56 -0700 From: Bart Van Assche To: Omar Sandoval Cc: linux-block@vger.kernel.org, Bart Van Assche Subject: [PATCH 9/9] Makefile: Do not suppress useful shellcheck warnings Date: Tue, 19 Jun 2018 13:23:53 -0700 Message-Id: <20180619202353.23631-10-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180619202353.23631-1-bart.vanassche@wdc.com> References: <20180619202353.23631-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All the shellcheck warnings that are currently suppressed are useful. Additionally, it is easy to avoid false positives for the currently suppressed categories of shellcheck warnings. Hence stop suppressing shellcheck warnings. See also commit 17a59e0dc212 ("Fix all shellcheck warnings"). Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn --- Makefile | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/Makefile b/Makefile index 14ba8341dae5..c4bffa2d3f32 100644 --- a/Makefile +++ b/Makefile @@ -4,21 +4,8 @@ all: clean: $(MAKE) -C src clean -# SC1090: "Can't follow non-constant source". We use variable sources all over -# the place. -# SC2034: "VARIABLE appears unused". All test scripts use this for the test -# metadata, and many helper functions define global variables. -# SC2119: "Use foo "$@" if function's $1 should mean script's $1". False -# positives on helpers like _init_scsi_debug. -# SC2154: "VARIABLE is referenced but not assigned". False positives on -# TEST_RUN[foo]=bar. -# SC2209: "Use var=$(command) to assign output (or quote to assign string)". -# Warns about DMESG_FILTER=cat, which is not going to confuse anyone who knows -# how to write shell scripts. -SHELLCHECK_EXCLUDE := SC1090,SC2034,SC2119,SC2154,SC2209 - check: - shellcheck -x -e $(SHELLCHECK_EXCLUDE) -f gcc check new common/* tests/*/[0-9]*[0-9] + shellcheck -x -f gcc check new common/* tests/*/[0-9]*[0-9] ! grep TODO tests/*/[0-9]*[0-9] .PHONY: all check