From patchwork Fri Jun 22 22:19:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10483163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ECC2860230 for ; Fri, 22 Jun 2018 22:19:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF2D528FF3 for ; Fri, 22 Jun 2018 22:19:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D444828FFB; Fri, 22 Jun 2018 22:19:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A0D828FF3 for ; Fri, 22 Jun 2018 22:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933738AbeFVWT4 (ORCPT ); Fri, 22 Jun 2018 18:19:56 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:59818 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933853AbeFVWTu (ORCPT ); Fri, 22 Jun 2018 18:19:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1529705991; x=1561241991; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=AXdNj6gO8ukguOI8y813ncNTGnewMtV8PXGWUNWqBYc=; b=Uei3dQNcR8oE6T0lO1vzoCQU6D8Fy4EGcnnQAbW+XBn6dYOvPwuFmhWt tPUU4gz3guQJMyllcl4ixcP1RZTaKR+J7mcJx5v6DH6ZLgDxpIEVILrdJ TSyyLFm2R8+lJWbRFosjY1ocoiwtoaISTLdrD7tx0PRRQWu7MDPYkNno+ eO9mZJqUIryyPfQmb+W4YM8Cps+BzLbVLMaxTAAdCWd6ZXu/ibwCuBo6b 6qJJ1pwlzoenjmwwwQx/vvnzIvE0ShK9+FXNlvWFshA6sqPAvYzVXT+eA 6ViXeBCdLSYeqaVdh8faSP2eY81a96UWvQwUQkxB3PFEKHrHmFecrNr28 A==; X-IronPort-AV: E=Sophos;i="5.51,259,1526313600"; d="scan'208";a="83827526" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 23 Jun 2018 06:19:48 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 22 Jun 2018 15:09:16 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com ([10.111.67.248]) by uls-op-cesaip01.wdc.com with ESMTP; 22 Jun 2018 15:19:48 -0700 From: Bart Van Assche To: Omar Sandoval Cc: linux-block@vger.kernel.org, Bart Van Assche Subject: [PATCH blktests 09/15] Makefile: Do not suppress useful shellcheck warnings Date: Fri, 22 Jun 2018 15:19:40 -0700 Message-Id: <20180622221946.10987-10-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180622221946.10987-1-bart.vanassche@wdc.com> References: <20180622221946.10987-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All the shellcheck warnings that are currently suppressed are useful. Additionally, it is easy to avoid false positives for the currently suppressed categories of shellcheck warnings. Hence stop suppressing shellcheck warnings. See also commit 17a59e0dc212 ("Fix all shellcheck warnings"). Signed-off-by: Bart Van Assche --- Makefile | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/Makefile b/Makefile index 14ba8341dae5..c4bffa2d3f32 100644 --- a/Makefile +++ b/Makefile @@ -4,21 +4,8 @@ all: clean: $(MAKE) -C src clean -# SC1090: "Can't follow non-constant source". We use variable sources all over -# the place. -# SC2034: "VARIABLE appears unused". All test scripts use this for the test -# metadata, and many helper functions define global variables. -# SC2119: "Use foo "$@" if function's $1 should mean script's $1". False -# positives on helpers like _init_scsi_debug. -# SC2154: "VARIABLE is referenced but not assigned". False positives on -# TEST_RUN[foo]=bar. -# SC2209: "Use var=$(command) to assign output (or quote to assign string)". -# Warns about DMESG_FILTER=cat, which is not going to confuse anyone who knows -# how to write shell scripts. -SHELLCHECK_EXCLUDE := SC1090,SC2034,SC2119,SC2154,SC2209 - check: - shellcheck -x -e $(SHELLCHECK_EXCLUDE) -f gcc check new common/* tests/*/[0-9]*[0-9] + shellcheck -x -f gcc check new common/* tests/*/[0-9]*[0-9] ! grep TODO tests/*/[0-9]*[0-9] .PHONY: all check