From patchwork Fri Jun 22 22:19:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10483165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD63460230 for ; Fri, 22 Jun 2018 22:19:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE58328FF3 for ; Fri, 22 Jun 2018 22:19:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C371828FFB; Fri, 22 Jun 2018 22:19:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CC6828FF3 for ; Fri, 22 Jun 2018 22:19:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933853AbeFVWT4 (ORCPT ); Fri, 22 Jun 2018 18:19:56 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:26982 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933858AbeFVWTv (ORCPT ); Fri, 22 Jun 2018 18:19:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1529705991; x=1561241991; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=WOrWaRWK0UILagioAtD3wEnS7N74cK8D8qK/kuz7CYs=; b=jC654l9R0O7/m+Gzq+QYpkd77zuCN9QdD06mJr57U+le9Zc0KGJ5mrUo nuneixfi6ncvVzcG4PeFu8KM4ZW9qcB8781faJM2FCOzXURCFFIHccH07 oZDkWPBfTyLIYX1xM7lkjyhjscrTYckGyIeBcLMjCGeGKKdEzEKByhOuv N/GYIr3dZvPN56XRMBv1uuj1UQ2yUmdjQxr4Hu2c5kSxwTn0eVNPWeLhy IEcUXwtBFq6e8ZlYh3QZ2PWlLOwzYBrivJId2Xvbtg468fq9m9HOpyxEp KqV3WrlssifsY+MCD0ydfckGBCNd+fXRquCeTAKFG/3WmNxmf+AHuz4Um A==; X-IronPort-AV: E=Sophos;i="5.51,259,1526313600"; d="scan'208";a="83827528" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 23 Jun 2018 06:19:48 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 22 Jun 2018 15:09:16 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com ([10.111.67.248]) by uls-op-cesaip01.wdc.com with ESMTP; 22 Jun 2018 15:19:48 -0700 From: Bart Van Assche To: Omar Sandoval Cc: linux-block@vger.kernel.org, Bart Van Assche Subject: [PATCH blktests 10/15] tests/meta/group: Fix shellcheck complaints Date: Fri, 22 Jun 2018 15:19:41 -0700 Message-Id: <20180622221946.10987-11-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180622221946.10987-1-bart.vanassche@wdc.com> References: <20180622221946.10987-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Avoid that shellcheck complains about unused global variables. Avoid that shellcheck complains about using cat instead of redirection. Signed-off-by: Bart Van Assche --- tests/meta/group | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/meta/group b/tests/meta/group index 4281ea175a78..bae91281c493 100644 --- a/tests/meta/group +++ b/tests/meta/group @@ -17,6 +17,8 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . +. common/shellcheck + group_requires() { if [[ -v META_REQUIRES_SKIP ]]; then SKIP_REASON="META_REQUIRES_SKIP was set" @@ -76,7 +78,7 @@ RIP: blk_dev_init+0x4/0x6 RSP: ffffc9000031fe70 ---[ end trace d9ab35f734a89f58 ]--- EOF - cat "$TMPDIR/dmesg" | while IFS= read -r line; do + while IFS= read -r line; do echo "$line" >> /dev/kmsg - done + done < "$TMPDIR/dmesg" }