From patchwork Wed Jun 27 19:09:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10492453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0192F601A0 for ; Wed, 27 Jun 2018 19:11:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12F6F29EBD for ; Wed, 27 Jun 2018 19:11:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1130029C3F; Wed, 27 Jun 2018 19:11:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DE6829EAB for ; Wed, 27 Jun 2018 19:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965444AbeF0TKB (ORCPT ); Wed, 27 Jun 2018 15:10:01 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34810 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965256AbeF0TJv (ORCPT ); Wed, 27 Jun 2018 15:09:51 -0400 Received: by mail-qt0-f194.google.com with SMTP id d23-v6so2646561qtp.1 for ; Wed, 27 Jun 2018 12:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=bxA6cMGXvEe6N+gMDPkoHZMx5A3XRvMVyzrtT6Xehm8=; b=Ee3iv0A2vwt6tjAvoeTSBp/LJm5unNt/ZMaoIK32wUShvaCQpHSIttfuevPkQeusA9 ie9q8bm581Xxy+ppauS1x08gdOFxvJv0MoU+N3WmpKGwwuGq1rf9lRwTUoWawUTF6mcl +tpEdIS4fVD3PPUj9RbIS5v0FIYMf0r4Bsc5dB37UF0qPSBta0MLG1sTGv7jObZ0LVyG o3iw5eQokSmmRIWYjg8+he77Ug5YeJlqw7Rk8lrbnT/PRl4FxWjIkgsvIzztQcWZrdai uPAwnsBWgtX5+vpkiAUOn+yGW/93Aqi1mVK+6ee5IFIr5LXCg67qIvtWtOiLyPOi83OB Zouw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=bxA6cMGXvEe6N+gMDPkoHZMx5A3XRvMVyzrtT6Xehm8=; b=OUhj06LXSlV8HX7dxf8lbVGfDSOwTHU1/ckksrhio9bCgKw+7eKoeg0f5DBbfrXSYs +h1hsahqoqrUvkQGnh0fmsyfJKjU4Qm1/O3VEKV5EdlUWO4IXtRU7A+c4/nzYEh3K1N6 paUZ+UuA49/0uPulU/RrsqXg9yKTzGemW4rER7Fjb91iPtydy2cAAO/sx6k1K8JuvGBr xZ+0X3lq3al78ZqufMxAQEMOPm5YgYH3KaqAhDfhc7yP6QWyYOH5M21zYdZBigHIfQ+Z GVzhifBci8wksh2Ziexgns0dxQHRm2BRPemo/7SvyD+R/84vkU0T1QDtbZ8ROp2yLDyr iG2w== X-Gm-Message-State: APt69E2GIflqcU8Nvq4cDxmmMsGKJ5LjakzNQZ7uIM1oNgKhPEeQLghe WGxsL5RDpHJC4sn9QATKrL/JgQ== X-Google-Smtp-Source: AAOMgpdYkGsTzYHP1GX6ogvZx6Me8KZXfVBbCMty7A+16gKYdUI94DrzUunMxFk0ArNtBSB749JLVw== X-Received: by 2002:a0c:99df:: with SMTP id y31-v6mr6553526qve.156.1530126591041; Wed, 27 Jun 2018 12:09:51 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id n21-v6sm4606075qkl.34.2018.06.27.12.09.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 12:09:50 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, linux-block@vger.kernel.org, kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, tj@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 05/14] swap, blkcg: issue swap io with the appropriate context Date: Wed, 27 Jun 2018 15:09:31 -0400 Message-Id: <20180627190940.4696-6-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180627190940.4696-1-josef@toxicpanda.com> References: <20180627190940.4696-1-josef@toxicpanda.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tejun Heo For backcharging we need to know who the page belongs to when swapping it out. We don't worry about things that do ->rw_page (zram etc) at the moment, we're only worried about pages that actually go to a block device. Signed-off-by: Tejun Heo Signed-off-by: Josef Bacik Acked-by: Johannes Weiner --- block/bio.c | 24 ++++++++++++++++++++++++ include/linux/bio.h | 7 +++++++ mm/page_io.c | 1 + 3 files changed, 32 insertions(+) diff --git a/block/bio.c b/block/bio.c index 57c4b1986e76..c77fe1b4caa8 100644 --- a/block/bio.c +++ b/block/bio.c @@ -2005,6 +2005,30 @@ EXPORT_SYMBOL(bioset_create); #ifdef CONFIG_BLK_CGROUP +#ifdef CONFIG_MEMCG +/** + * bio_associate_blkcg_from_page - associate a bio with the page's blkcg + * @bio: target bio + * @page: the page to lookup the blkcg from + * + * Associate @bio with the blkcg from @page's owning memcg. This works like + * every other associate function wrt references. + */ +int bio_associate_blkcg_from_page(struct bio *bio, struct page *page) +{ + struct cgroup_subsys_state *blkcg_css; + + if (unlikely(bio->bi_css)) + return -EBUSY; + if (!page->mem_cgroup) + return 0; + blkcg_css = cgroup_get_e_css(page->mem_cgroup->css.cgroup, + &io_cgrp_subsys); + bio->bi_css = blkcg_css; + return 0; +} +#endif /* CONFIG_MEMCG */ + /** * bio_associate_blkcg - associate a bio with the specified blkcg * @bio: target bio diff --git a/include/linux/bio.h b/include/linux/bio.h index f2f3f1428e81..eef1e8877048 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -545,6 +545,13 @@ do { \ #define bio_dev(bio) \ disk_devt((bio)->bi_disk) +#if defined(CONFIG_MEMCG) && defined(CONFIG_BLK_CGROUP) +int bio_associate_blkcg_from_page(struct bio *bio, struct page *page); +#else +static inline int bio_associate_blkcg_from_page(struct bio *bio, + struct page *page) { return 0; } +#endif + #ifdef CONFIG_BLK_CGROUP int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css); int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg); diff --git a/mm/page_io.c b/mm/page_io.c index a552cb37e220..aafd19ec1db4 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -339,6 +339,7 @@ int __swap_writepage(struct page *page, struct writeback_control *wbc, goto out; } bio->bi_opf = REQ_OP_WRITE | REQ_SWAP | wbc_to_write_flags(wbc); + bio_associate_blkcg_from_page(bio, page); count_swpout_vm_event(page); set_page_writeback(page); unlock_page(page);