From patchwork Mon Jul 16 16:12:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10527163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7EEAE600D0 for ; Mon, 16 Jul 2018 16:12:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72C9B28B7D for ; Mon, 16 Jul 2018 16:12:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 645B128D6A; Mon, 16 Jul 2018 16:12:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07A1128B7D for ; Mon, 16 Jul 2018 16:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729927AbeGPQkb (ORCPT ); Mon, 16 Jul 2018 12:40:31 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:46005 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbeGPQkb (ORCPT ); Mon, 16 Jul 2018 12:40:31 -0400 Received: by mail-qk0-f193.google.com with SMTP id c192-v6so20750616qkg.12 for ; Mon, 16 Jul 2018 09:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=ryPqB0OzrcTTFqgRqNZxKgDfpjTMFbM3Jc7jONVneW4=; b=LL026kN+ShrahcTK+TaOjUZ/PNs3ixnMT2W4kk0kZckPeKiqERI7G0O7Zrk1JK2r7n QJg15SSIyvPI6+IRK9Tk1Yoiq0PpiUWqdbhKr59lrCvYD6ty9FOpiL+qdOuyx3WQXbra FUsHIgiME6Y3MEqNnxnkTBLqbh0QEbsP0S84yaIIL7WCc6Ly/qGinGHrJAOPIJFxblL/ C9CPHGCP02XHSg0F9pL+XthKOq8JqLh029wt448kvL83DIDOasTZgAAXmQLSrrzCg+2b DIBR7ifa1CjqoV8dcpwq7OqjBSTGe/Mr7DtDjwDRCg4R0N5Q4sktaddV0kz+nFiDqwL/ iUMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ryPqB0OzrcTTFqgRqNZxKgDfpjTMFbM3Jc7jONVneW4=; b=FIcajKTfY8fmgTUn/Ed5ZvyxmqZlt7jiqsZt3FC6Jvi8rTm0Gp5INlMvJX508+dJPW ++9kGjfEcgusU6ufIWP60ERsjYVzpBL/Y6IZwIGStJW6sboJ0G6SZ8cU03Qbf69hF3Y2 1hz1Nz8A5pYyA33tYdvqcF6OG+IERRDs/TjogtP+2Yn303zOWf4jKXHxyCfOx45xBvWW bej8X+T49VdRH3/wxbW75giGwS38J4Kz81t3GKjBxdnX4bUxQQuLl0ByJSd/WdbE5BzZ 4LtSkgf883H82V7RbecoijXjjsksr8fpcqrpxeXalvvDTiY16s+zKOCQtH81b+OLoPVs c4cA== X-Gm-Message-State: AOUpUlFLRhyGh/V6QXVSzGPTsv0GAq6C1UR72t37c+6BTgOXZWDkPjvz gP82EaM2rInMzlzvEJTSKuqZ7A== X-Google-Smtp-Source: AAOMgpfrYplD4mDnKfl7I04/6lINmHlXd8IgtOs97hcW7Ch6In2YH4Rc+AnC5HPsNILzoDdbjCNA9g== X-Received: by 2002:a37:4a94:: with SMTP id x142-v6mr13411883qka.110.1531757544830; Mon, 16 Jul 2018 09:12:24 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id n24-v6sm33548003qkh.39.2018.07.16.09.12.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Jul 2018 09:12:24 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, linux-block@vger.kernel.org, kernel-team@fb.com Cc: Josef Bacik Subject: [PATCH 1/2] blk-iolatency: don't change the latency window Date: Mon, 16 Jul 2018 12:12:22 -0400 Message-Id: <20180716161223.21486-1-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Josef Bacik Early versions of these patches had us waiting for seconds at a time during submission, so we had to adjust the timing window we monitored for latency. Now we don't do things like that so this is unnecessary code. Signed-off-by: Josef Bacik --- block/blk-iolatency.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index b59e5451680b..893f888eebb1 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -468,16 +468,6 @@ static void iolatency_check_latencies(struct iolatency_grp *iolat, u64 now) } preempt_enable(); - /* - * Our average exceeded our window, scale up our window so we are more - * accurate, but not more than the global timer. - */ - if (stat.mean > iolat->cur_win_nsec) { - iolat->cur_win_nsec <<= 1; - iolat->cur_win_nsec = - max_t(u64, iolat->cur_win_nsec, NSEC_PER_SEC); - } - parent = blkg_to_lat(blkg->parent); if (!parent) return;