From patchwork Thu Jul 26 01:46:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauricio Faria de Oliveira X-Patchwork-Id: 10545051 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A1A114E2 for ; Thu, 26 Jul 2018 01:46:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 854EF29FAC for ; Thu, 26 Jul 2018 01:46:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 838A42AB1A; Thu, 26 Jul 2018 01:46:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1BF3B2AAFE for ; Thu, 26 Jul 2018 01:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728716AbeGZDBP (ORCPT ); Wed, 25 Jul 2018 23:01:15 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38300 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbeGZDBO (ORCPT ); Wed, 25 Jul 2018 23:01:14 -0400 Received: from mail-qk0-f200.google.com ([209.85.220.200]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fiVMf-0005fG-6T for linux-block@vger.kernel.org; Thu, 26 Jul 2018 01:46:49 +0000 Received: by mail-qk0-f200.google.com with SMTP id u68-v6so113463qku.5 for ; Wed, 25 Jul 2018 18:46:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=azGIAqjhubvPhiTxDMeOWSUNh8NUi3e8ryLgN8ahl9w=; b=B/spiSNzqOmAWY4j6UPmRbF+v2Qxb+WG2nVWNtk4SNveaCD/N3s3zMp5kRj3GYzCK8 p0Cpn//mgSu5al/8u6ZKjNPh3EpbQK1LzfGcwfLEogTlUbnheMXFHJfmxArpFUNcBfu4 nFmuyW7IRWZYTc4p9Nq8ZF4AhL3tbE0trvoYxqlMTNF8GzRfIGGsta4pOLt7hDl7wta/ DTTetjBj1NObxJncPLK2lTtvv22ZumqqfSxWpH2BAAvNgl3mWHyT1Kws8wsWyZoK6Qzv 5CJN7i6Gm/SSYfaMSL5TMbvsbZ6YQcIfWMzJ9q1QatuYLkH3Fz1pZPySIfAEhOtS1lqO YFhQ== X-Gm-Message-State: AOUpUlE9rGOGaHp3AByGk5aRks7hx50AeKMu6gaolGPmg6Cf3F4tp9X+ TnFDY80j7/gX6/+bDWS9WuiTokMFmpX4+V8IovqqrIBHnf6Zt2/Y6JPAWoQK/VDDiIdvtWE5Xsw Hp4DvrngMHbbN2S4QhEbWOsFr2JFfPWU2oUn+g+DU X-Received: by 2002:a37:6a82:: with SMTP id f124-v6mr21434408qkc.296.1532569608417; Wed, 25 Jul 2018 18:46:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcaaDNGU5Wh0qrW2GcuQ/dhhaPZP7JNKqlslNR/AB17iX1Y4f7BSTxTyw5qC+P3Hd+jKbH9nA== X-Received: by 2002:a37:6a82:: with SMTP id f124-v6mr21434399qkc.296.1532569608260; Wed, 25 Jul 2018 18:46:48 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:77dd:8111:28ad:fd9c:9a4d]) by smtp.gmail.com with ESMTPSA id r4-v6sm19619qtm.10.2018.07.25.18.46.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 18:46:47 -0700 (PDT) From: Mauricio Faria de Oliveira To: axboe@kernel.dk Cc: phdm@macqel.be, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.axtens@canonical.com Subject: [PATCH 2/2] partitions/aix: append null character to print data from disk Date: Wed, 25 Jul 2018 22:46:29 -0300 Message-Id: <20180726014629.30411-3-mfo@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180726014629.30411-1-mfo@canonical.com> References: <20180726014629.30411-1-mfo@canonical.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if properly initialized, the lvname array (i.e., strings) is read from disk, and might contain corrupt data (e.g., lack the null terminating character for strings). So, make sure the partition name string used in pr_warn() has the null terminating character. Fixes: 6ceea22bbbc8 ("partitions: add aix lvm partition support files") Suggested-by: Daniel J. Axtens Signed-off-by: Mauricio Faria de Oliveira --- block/partitions/aix.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/partitions/aix.c b/block/partitions/aix.c index 850cbd1860d4..903f3ed175d0 100644 --- a/block/partitions/aix.c +++ b/block/partitions/aix.c @@ -283,10 +283,14 @@ int aix_partition(struct parsed_partitions *state) next_lp_ix += 1; } for (i = 0; i < state->limit; i += 1) - if (lvip[i].pps_found && !lvip[i].lv_is_contiguous) + if (lvip[i].pps_found && !lvip[i].lv_is_contiguous) { + char tmp[sizeof(n[i].name) + 1]; // null char + + snprintf(tmp, sizeof(tmp), "%s", n[i].name); pr_warn("partition %s (%u pp's found) is " "not contiguous\n", - n[i].name, lvip[i].pps_found); + tmp, lvip[i].pps_found); + } kfree(pvd); } kfree(n);