| Message ID | 20180802110625.12463-1-mb@lightnvm.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | lightnvm: remove dependencies on BLK_DEV_NVME and PCI | expand |
> On 2 Aug 2018, at 13.06, Matias Bjørling <mb@lightnvm.io> wrote: > > No need to force NVMe device driver to be compiled in if the > lightnvm subsystem is selected. Also no need for PCI to be selected > as well, as it would be selected by the device driver that hooks into > the subsystem. > > Signed-off-by: Matias Bjørling <mb@lightnvm.io> > --- > drivers/lightnvm/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig > index 439bf90d084d..a872cd720967 100644 > --- a/drivers/lightnvm/Kconfig > +++ b/drivers/lightnvm/Kconfig > @@ -4,8 +4,7 @@ > > menuconfig NVM > bool "Open-Channel SSD target support" > - depends on BLOCK && PCI > - select BLK_DEV_NVME > + depends on BLOCK > help > Say Y here to get to enable Open-channel SSDs. > > -- > 2.11.0 Looks like a good dependency cleanup. Though the nvme driver is the only one that hooks into LigthNVM today, so it will have to be compiled anyway. Reviewed-by: Javier González <javier@cnexlabs.com>
diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig index 439bf90d084d..a872cd720967 100644 --- a/drivers/lightnvm/Kconfig +++ b/drivers/lightnvm/Kconfig @@ -4,8 +4,7 @@ menuconfig NVM bool "Open-Channel SSD target support" - depends on BLOCK && PCI - select BLK_DEV_NVME + depends on BLOCK help Say Y here to get to enable Open-channel SSDs.
No need to force NVMe device driver to be compiled in if the lightnvm subsystem is selected. Also no need for PCI to be selected as well, as it would be selected by the device driver that hooks into the subsystem. Signed-off-by: Matias Bjørling <mb@lightnvm.io> --- drivers/lightnvm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)