From patchwork Thu Aug 16 22:45:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 10568265 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 574D613B6 for ; Thu, 16 Aug 2018 22:45:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C6032B8C7 for ; Thu, 16 Aug 2018 22:45:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 309582B8D2; Thu, 16 Aug 2018 22:45:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B7A062B8C7 for ; Thu, 16 Aug 2018 22:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725949AbeHQBq1 (ORCPT ); Thu, 16 Aug 2018 21:46:27 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:21960 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbeHQBq1 (ORCPT ); Thu, 16 Aug 2018 21:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1534459561; x=1565995561; h=from:to:cc:subject:date:message-id; bh=UGe6w88fw7/toqOCIXK11L0R6eHhB3e43mmXnSwjn0w=; b=kbHzeXwAdqzNtnT1c9oJ9muSs4Kq9QKX0mDlgg2j8d0xzXmY/r6yJLjR SAiiTCm2gruBVoRYrmDsXByhFmwD9rPj5Th+oHUIBuBexeqYU475uymXQ V/lXSXvOyPhlqh+IWrIrjZPPZdkmRfJKNPZDSuu2JICAjErxjobX0XAjx ZObXiKbOQndQazPWF3qV2LnWXL5uSkuFK6tBj2SjHm+F+hmWz9/CQpE1g 09zPfn/YUgtU5vwJ36e9XApwcY2o0OUmLSkEl+jP7Z4vgPtw7LQWzikS/ ZgC90aJovLUgqip3rLdIiUI9cZbL3vpj2nLtGi+JCt3joi+qjJmqjwa8H w==; X-IronPort-AV: E=Sophos;i="5.53,248,1531756800"; d="scan'208";a="185162487" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 17 Aug 2018 06:46:00 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP; 16 Aug 2018 15:33:28 -0700 Received: from qemu.hgst.com ([10.202.65.140]) by uls-op-cesaip01.wdc.com with ESMTP; 16 Aug 2018 15:45:32 -0700 From: Chaitanya Kulkarni To: linux-block@vger.kernel.org Cc: Chaitanya Kulkarni Subject: [PATCH] block: remove duplicate initialization Date: Thu, 16 Aug 2018 15:45:29 -0700 Message-Id: <20180816224529.3401-1-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.17.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes the duplicate initialization of q->queue_head in the blk_alloc_queue_node(). This removes the 2nd initialization so that we preserve the initialization order same as declaration present in struct request_queue. Signed-off-by: Chaitanya Kulkarni Reviewed-by: Omar Sandoval --- block/blk-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 21c7cb35d3b4..dee56c282efb 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1036,7 +1036,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id, laptop_mode_timer_fn, 0); timer_setup(&q->timeout, blk_rq_timed_out_timer, 0); INIT_WORK(&q->timeout_work, NULL); - INIT_LIST_HEAD(&q->queue_head); INIT_LIST_HEAD(&q->timeout_list); INIT_LIST_HEAD(&q->icq_list); #ifdef CONFIG_BLK_CGROUP