From patchwork Tue Oct 9 11:11:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matias Bjorling X-Patchwork-Id: 10632313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 51DFB112B for ; Tue, 9 Oct 2018 11:17:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32EDE28A73 for ; Tue, 9 Oct 2018 11:17:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2440128A85; Tue, 9 Oct 2018 11:17:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1365428A45 for ; Tue, 9 Oct 2018 11:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727081AbeJISdh (ORCPT ); Tue, 9 Oct 2018 14:33:37 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44874 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbeJISal (ORCPT ); Tue, 9 Oct 2018 14:30:41 -0400 Received: by mail-pl1-f194.google.com with SMTP id p25-v6so658751pli.11 for ; Tue, 09 Oct 2018 04:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=obBBG+/vjhkx2sjBc8D/J/RQKkavutEZvS8nBnwz9NQ=; b=ZY3vPO1P9XcgjiE8poykd+e3chkQOCCFPcPXCkQr2j30j+1ZfPxRmc5WqXkGGn06Yr P0Ab/EAxMHoZv7qFkpxoS1uxs+g9gRWYGKfDxVVlRy3V5Psm7FVB2q44cyJyWFbXtDCe PUgn0FVLnl25OqU6V5+Sz8LZb75THbtKKrbrffsusgs6NcsTXf7XooDIgfAmpPzA45lV 864H5J3HA1IDS7MjtcdpaKaTPsSNgah93EExoF0t0W8XtNg+kz/lMnU6N7hsXYh72q1p kQI4ztaJCTDTgCO5mX/ThaK9MCPB6o7ggzp7ZvbTcDz0fLUDlcZ+1oKOS5VrrQqQdfEP 8vJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=obBBG+/vjhkx2sjBc8D/J/RQKkavutEZvS8nBnwz9NQ=; b=hdHYw0QbeRwFBVyKwJx7WPoI3BhPk54DRwhOjN9qIuuEZQTumz1545yl3xEjAuZdcX rInCmnX/F5HqMlGFkEspiHF6tR6rLxE36DggMMz84y8zJJE1/K+PH4hEL86QNA7OoVvX 6XKY2xakHYDWcl3KMNG5E+YBQjxj4EGl7FvbR+bvnOUara5UdiVwkwhNGFYW0uu50fhY XPfr+IUSe3ww0dDSVatepnjRpM5YmC/siFg3uEvPSf6lWMXNFRap0Jcx+iK6HhzHLXBH +Y65Xvg9NMfQMb7q+awyx9PKThjS2NqJxuoYDGR6JICaPbr+4XK8TnSqpvp1oo0EFGP7 jAjw== X-Gm-Message-State: ABuFfojOmiyEjR8N2/pARZ+wNfwA7UORfqgzrnmu1aInpeXnbGrLG9nM XWfw3pDGWC22jPGCqM9EYJ0AqYechZScUw== X-Google-Smtp-Source: ACcGV60MnDvnJPyfUm1/JoYkdcfOSpjUsccNN7VcldwO7uYNC7QyTKv75Q3JXj6aAyxw4x5FqHqUzQ== X-Received: by 2002:a17:902:6a8b:: with SMTP id n11-v6mr27620538plk.16.1539083655085; Tue, 09 Oct 2018 04:14:15 -0700 (PDT) Received: from skyninja.hgst.com (rap-us.hgst.com. [199.255.44.250]) by smtp.gmail.com with ESMTPSA id p1-v6sm25342380pff.128.2018.10.09.04.14.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Oct 2018 04:14:13 -0700 (PDT) From: =?utf-8?q?Matias_Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Holmberg , =?utf-8?q?Matias_Bj=C3=B8rling?= Subject: [GIT PULL 18/45] lightnvm: pblk: remove unused parameters in pblk_up_rq Date: Tue, 9 Oct 2018 13:11:48 +0200 Message-Id: <20181009111215.7653-19-mb@lightnvm.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181009111215.7653-1-mb@lightnvm.io> References: <20181009111215.7653-1-mb@lightnvm.io> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Hans Holmberg The parameters nr_ppas and ppa_list are not used, so remove them. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 3 +-- drivers/lightnvm/pblk-write.c | 5 ++--- drivers/lightnvm/pblk.h | 3 +-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index e1207a4f9d54..bb1a7cc24cbb 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c @@ -1929,8 +1929,7 @@ void pblk_up_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas) up(&rlun->wr_sem); } -void pblk_up_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas, - unsigned long *lun_bitmap) +void pblk_up_rq(struct pblk *pblk, unsigned long *lun_bitmap) { struct nvm_tgt_dev *dev = pblk->dev; struct nvm_geo *geo = &dev->geo; diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c index c20bb7f6d703..cd579b440b56 100644 --- a/drivers/lightnvm/pblk-write.c +++ b/drivers/lightnvm/pblk-write.c @@ -81,8 +81,7 @@ static void pblk_complete_write(struct pblk *pblk, struct nvm_rq *rqd, #ifdef CONFIG_NVM_PBLK_DEBUG atomic_long_sub(c_ctx->nr_valid, &pblk->inflight_writes); #endif - - pblk_up_rq(pblk, rqd->ppa_list, rqd->nr_ppas, c_ctx->lun_bitmap); + pblk_up_rq(pblk, c_ctx->lun_bitmap); pos = pblk_rb_sync_init(&pblk->rwb, &flags); if (pos == c_ctx->sentry) { @@ -215,7 +214,7 @@ static void pblk_submit_rec(struct work_struct *work) pblk_map_remaining(pblk, ppa_list); pblk_queue_resubmit(pblk, c_ctx); - pblk_up_rq(pblk, rqd->ppa_list, rqd->nr_ppas, c_ctx->lun_bitmap); + pblk_up_rq(pblk, c_ctx->lun_bitmap); if (c_ctx->nr_padded) pblk_bio_free_pages(pblk, rqd->bio, c_ctx->nr_valid, c_ctx->nr_padded); diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h index 9068b158de22..0ca67e8f99d5 100644 --- a/drivers/lightnvm/pblk.h +++ b/drivers/lightnvm/pblk.h @@ -827,8 +827,7 @@ void pblk_up_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas); void pblk_down_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas, unsigned long *lun_bitmap); void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas); -void pblk_up_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas, - unsigned long *lun_bitmap); +void pblk_up_rq(struct pblk *pblk, unsigned long *lun_bitmap); int pblk_bio_add_pages(struct pblk *pblk, struct bio *bio, gfp_t flags, int nr_pages); void pblk_bio_free_pages(struct pblk *pblk, struct bio *bio, int off,