From patchwork Tue Oct 9 11:11:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matias Bjorling X-Patchwork-Id: 10632259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EF96C16B1 for ; Tue, 9 Oct 2018 11:14:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFE8228A6E for ; Tue, 9 Oct 2018 11:14:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1EBA28A73; Tue, 9 Oct 2018 11:14:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6814828A6E for ; Tue, 9 Oct 2018 11:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727546AbeJISap (ORCPT ); Tue, 9 Oct 2018 14:30:45 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37462 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbeJISao (ORCPT ); Tue, 9 Oct 2018 14:30:44 -0400 Received: by mail-pg1-f196.google.com with SMTP id c10-v6so656655pgq.4 for ; Tue, 09 Oct 2018 04:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8/TVf+su0XnaNLtGwghLacA6h4HeQqhXaBp14oLVNmc=; b=SD3CJNaDS2LWRQCfgvm59ZAgJLslYLaOi7H6IM4o84aU6zbvim9JriVThQa+IE3vkq p9XtPMVClTNn/Uim15lnG+HvAelrmbzuSex7CpuSz6ELBrnfi1qdcABmIvUWtEGwhRHT 0364lCTK7ds9xK9yopnTokCfP7re7ndymGtr0C8cY66yywboZNQO3tdNptnq+HCJ1mpO 64Ipmn4gnd8c3XemgmwlStBTiOBXWWYMumYL6gU3LZvW9ESudB/UwnfjtzxLf0dPsAb7 JDaODzM+Ele4YUImoGvVZX3gwVweZv05AUQZpmDMWPP95JWPk7zfS1idVEiHx897rEIp YPDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8/TVf+su0XnaNLtGwghLacA6h4HeQqhXaBp14oLVNmc=; b=D2tZqMDb/ssuQCtzcpdNKERh86H40rhAIHwddM6jGgo9+YhW6433gf4A2qFt1bHRET KtVWLtg0D1BXWckj4UGcjf/A0qS5F/ZOAE+136U/ScUSsisx1JqyjPqsXILcmRtOLSGY z7slTsqH8foShELejM6m3ERPkSFjrl1YBMjouFuCaQSjoDyZTjgrK4ycjLRlY2nL/0FV KlM3TAYHwKpHBL4RThckEApfoR7yFhBFXQvmt5L9SNmzdSHbLeDtfDGS8uoMONQv6hgW a7RSfEB0sK8wNG7hORQTZ8NwYIO/Q8V+1gqEPrdr78xMNh3U0rpeb1zvBUsZH6pWm0dG +7Vg== X-Gm-Message-State: ABuFfog52IBra9TS66xqHGhhS51WIDFElJtRqer43vHSdcSIfwzkFjOh VC1AEQ5g2Z2vJwomWdd31IIWNg== X-Google-Smtp-Source: ACcGV63ZBOOkkmzz2yQW7ZwoUkliTO/+UezP4P/eEBxyZ97Ng8ZRKJBgF6kHcpp5yItbDxpG0d6LhQ== X-Received: by 2002:a63:1f0a:: with SMTP id f10-v6mr25051807pgf.313.1539083658326; Tue, 09 Oct 2018 04:14:18 -0700 (PDT) Received: from skyninja.hgst.com (rap-us.hgst.com. [199.255.44.250]) by smtp.gmail.com with ESMTPSA id p1-v6sm25342380pff.128.2018.10.09.04.14.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Oct 2018 04:14:17 -0700 (PDT) From: =?utf-8?q?Matias_Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Holmberg , =?utf-8?q?Matias_Bj=C3=B8rling?= Subject: [GIT PULL 19/45] lightnvm: pblk: fix up prints in pblk_read_check_rand Date: Tue, 9 Oct 2018 13:11:49 +0200 Message-Id: <20181009111215.7653-20-mb@lightnvm.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181009111215.7653-1-mb@lightnvm.io> References: <20181009111215.7653-1-mb@lightnvm.io> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Hans Holmberg The prefix when printing ppas in pblk_read_check_rand should be "rnd" not "seq", so fix this so we can differentiate between lba missmatches in random and sequential reads. Also change the print order so we align with pblk_read_check_seq, printing read lba first. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c index d3ff8c3e9010..829e92857289 100644 --- a/drivers/lightnvm/pblk-read.c +++ b/drivers/lightnvm/pblk-read.c @@ -149,10 +149,10 @@ static void pblk_read_check_rand(struct pblk *pblk, struct nvm_rq *rqd, #ifdef CONFIG_NVM_PBLK_DEBUG struct ppa_addr *ppa_list = nvm_rq_to_ppa_list(rqd); - print_ppa(pblk, &ppa_list[j], "seq", j); + print_ppa(pblk, &ppa_list[j], "rnd", j); #endif pblk_err(pblk, "corrupted read LBA (%llu/%llu)\n", - lba, meta_lba); + meta_lba, lba); WARN_ON(1); }