From patchwork Tue Oct 9 11:11:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matias Bjorling X-Patchwork-Id: 10632331 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C12C715E8 for ; Tue, 9 Oct 2018 11:17:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1E1928A45 for ; Tue, 9 Oct 2018 11:17:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 960BF28A6E; Tue, 9 Oct 2018 11:17:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48C6A28A45 for ; Tue, 9 Oct 2018 11:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbeJISaI (ORCPT ); Tue, 9 Oct 2018 14:30:08 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33508 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727095AbeJISaH (ORCPT ); Tue, 9 Oct 2018 14:30:07 -0400 Received: by mail-pg1-f194.google.com with SMTP id y18-v6so665465pge.0 for ; Tue, 09 Oct 2018 04:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I1p9bXnHXgng+Azijy0DrFN05uFEZCB7dmzLswOYo5Y=; b=Blkhwp1xJbWp35U1e6Uu9LYfhiCdE/9ugrt25jlgOs+I4H3cX9UP5a0H84yde+b4ve p/gyDKnwI9+gW2RhZtH+DXQV2w+KG987FBoMqy2flrWepV9JxKgftBieBKMZY3JVAHhd sQHXdwxbCi0muW5czh75wuRpiJYcZ9GzEuHxtG2pQlOI6bJGsH2PfZTHh12aDwraJNRb jeLn7R5r8O5rrTYvdL64ttaVdXYUyTGyoHBichHpeAsESzswnvr8EGluEMPfIwnxip6J ndqI2a7hizK3Fk4fTV6yGnHl3jTvxcU00anMVIBQvjVOEQOcljGnK5QG6LnqgFBT/akD TzKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I1p9bXnHXgng+Azijy0DrFN05uFEZCB7dmzLswOYo5Y=; b=h4W/2MHSuGgFoJQjmQchTQLlfcxv1CEp63PWzp70v8jnJhuq9DIsvwxRcPr1Sw27xA qj4lATNqXD9fWjMp0b8c6yDp0aCx2RhcHx4PZP42B7gN336lodqamLy8IPYIUfsu3irC A7S6HMzyHUIgzH4CrnYn9ZqDuEmQKHXrmPi30KjACRpesDYvia1op69qlxZVzr/PRGKT 2Ym/Aow2K8K40/XFW2/gSKd0eD1qmsPyJLa3oiefVHxuhPjgxp0KMUaaegmeLUhKZU5p srJobpg5PB1pbPkZaC9NtsihycPuNm56vI2gpdZOenhBQPNSX8lnYNQD87PyYywEUH6i 1mwQ== X-Gm-Message-State: ABuFfog84SGkfWI6A2clQrNIg2q8+lQ/vb88A9V0BYqM+JSN21fhmPAS uxGsPwuyfZCFnQJLKvJRVtjozHVoBovAsA== X-Google-Smtp-Source: ACcGV61ZNXTE31soF3gokNKJoRqUisMJt41vRMrSsFQe4+uzPGOO55XmqHeifMVOtrUVDx+semBr0Q== X-Received: by 2002:a63:194a:: with SMTP id 10-v6mr20928494pgz.192.1539083620362; Tue, 09 Oct 2018 04:13:40 -0700 (PDT) Received: from skyninja.hgst.com (rap-us.hgst.com. [199.255.44.250]) by smtp.gmail.com with ESMTPSA id p1-v6sm25342380pff.128.2018.10.09.04.13.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Oct 2018 04:13:39 -0700 (PDT) From: =?utf-8?q?Matias_Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Mat?= =?utf-8?q?ias_Bj=C3=B8rling?= Subject: [GIT PULL 08/45] lightnvm: pblk: fix incorrect min_write_pgs Date: Tue, 9 Oct 2018 13:11:38 +0200 Message-Id: <20181009111215.7653-9-mb@lightnvm.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181009111215.7653-1-mb@lightnvm.io> References: <20181009111215.7653-1-mb@lightnvm.io> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The calculation of pblk->min_write_pgs should only use the optimal write size attribute provided by the drive, it does not correlate to the memory page size of the system, which can be smaller or larger than the LBA size reported. Signed-off-by: Matias Bjørling Reviewed-by: Javier González --- drivers/lightnvm/pblk-init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index 9119c64d6f62..8adc8ac8b03c 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -371,7 +371,7 @@ static int pblk_core_init(struct pblk *pblk) atomic64_set(&pblk->nr_flush, 0); pblk->nr_flush_rst = 0; - pblk->min_write_pgs = geo->ws_opt * (geo->csecs / PAGE_SIZE); + pblk->min_write_pgs = geo->ws_opt; max_write_ppas = pblk->min_write_pgs * geo->all_luns; pblk->max_write_pgs = min_t(int, max_write_ppas, NVM_MAX_VLBA); pblk_set_sec_per_write(pblk, pblk->min_write_pgs);