From patchwork Wed Dec 19 22:43:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dennis Zhou X-Patchwork-Id: 10738247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2177E746 for ; Wed, 19 Dec 2018 22:44:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 111B9285C3 for ; Wed, 19 Dec 2018 22:44:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 058AC286A8; Wed, 19 Dec 2018 22:44:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3C4E285C3 for ; Wed, 19 Dec 2018 22:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbeLSWn7 (ORCPT ); Wed, 19 Dec 2018 17:43:59 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:34233 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726716AbeLSWn6 (ORCPT ); Wed, 19 Dec 2018 17:43:58 -0500 Received: by mail-qt1-f196.google.com with SMTP id r14so24218693qtp.1; Wed, 19 Dec 2018 14:43:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aMlWOxxanyWGhdz+rklKQu8J3FMqqWnFQG+OHWd/InI=; b=pvAzb+ARhosBn3v55ja8uY+Z27mpa5cQ95De7L4VNhplM9AeSl/WwcMvRXo4FQ8hsp ea6w4K+apAG3oRdiab2wfLOuVbh0GsEcTmRBUtYuv/Cysazr7bnKARY3yWrWF3UjXEoe 68BTpjGY/NMisc1sEWhDGj5ChGwQX/FTWS+LibvJG/voqsHPea2rK/sbcrQD3IQGQsew tb4RRiU9R7TcerwfyNN9gAk0GBsKXinq49XwzWiLCJdYO4AlCEgVS3s95rTVugLHpHFI 6fNiJoq0YsyJc3o+vle9PQmYDnjf7i89ExZ7kOqQ0H+084ZPqlNXvBPve+x+AFNSAN6y UhQg== X-Gm-Message-State: AA+aEWaM24nspCIzYKEoLSKqHwg2jjN3O6ikB5pLgOfFjg8yFkJrYmIu ULmiYlNYOXPeGRl6k/pyZ00= X-Google-Smtp-Source: AFSGD/UY2NF/Fie5jPrNxh2ePUj+s+uTUxFTHiJkwIP1cYO+5i86vv0dqjAf/BTZgmaLkluDUv4/Kw== X-Received: by 2002:a0c:8ecc:: with SMTP id y12mr23292996qvb.41.1545259437865; Wed, 19 Dec 2018 14:43:57 -0800 (PST) Received: from dennisz-mbp.thefacebook.com ([199.201.65.2]) by smtp.gmail.com with ESMTPSA id 83sm3524638qkz.73.2018.12.19.14.43.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Dec 2018 14:43:57 -0800 (PST) From: Dennis Zhou To: Jens Axboe , Tejun Heo Cc: kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Dennis Zhou Subject: [PATCH] blkcg: remove unused __blkg_release_rcu() Date: Wed, 19 Dec 2018 16:43:53 -0600 Message-Id: <20181219224353.32763-1-dennis@kernel.org> X-Mailer: git-send-email 2.13.5 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP An earlier commit 7fcf2b033b84 ("blkcg: change blkg reference counting to use percpu_ref") moved around the release call from blkg_put() to be a part of the percpu_ref cleanup. Remove the additional unused code which should have been removed earlier. Signed-off-by: Dennis Zhou --- block/blk-cgroup.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index c8cc1cbb6370..2bed5725aa03 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -438,29 +438,6 @@ static void blkg_destroy_all(struct request_queue *q) spin_unlock_irq(&q->queue_lock); } -/* - * A group is RCU protected, but having an rcu lock does not mean that one - * can access all the fields of blkg and assume these are valid. For - * example, don't try to follow throtl_data and request queue links. - * - * Having a reference to blkg under an rcu allows accesses to only values - * local to groups like group stats and group rate limits. - */ -void __blkg_release_rcu(struct rcu_head *rcu_head) -{ - struct blkcg_gq *blkg = container_of(rcu_head, struct blkcg_gq, rcu_head); - - /* release the blkcg and parent blkg refs this blkg has been holding */ - css_put(&blkg->blkcg->css); - if (blkg->parent) - blkg_put(blkg->parent); - - wb_congested_put(blkg->wb_congested); - - blkg_free(blkg); -} -EXPORT_SYMBOL_GPL(__blkg_release_rcu); - static int blkcg_reset_stats(struct cgroup_subsys_state *css, struct cftype *cftype, u64 val) {