diff mbox series

lightnvm: pblk: use vfree to free metadata on error path

Message ID 20190122101759.31201-1-hans@owltronix.com (mailing list archive)
State New, archived
Headers show
Series lightnvm: pblk: use vfree to free metadata on error path | expand

Commit Message

Hans Holmberg Jan. 22, 2019, 10:17 a.m. UTC 
From: Hans Holmberg <hans.holmberg@cnexlabs.com>

As chunk metadata is allocated using vmalloc, we need to free it
using vfree.

Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page")
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
---
 drivers/lightnvm/pblk-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matias Bjorling Jan. 22, 2019, 7:48 p.m. UTC | #1 
On 1/22/19 11:17 AM, hans@owltronix.com wrote:
> From: Hans Holmberg <hans.holmberg@cnexlabs.com>
> 
> As chunk metadata is allocated using vmalloc, we need to free it
> using vfree.
> 
> Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page")
> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
> ---
>   drivers/lightnvm/pblk-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 1ff165351180..1b5ff51faa63 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -141,7 +141,7 @@ struct nvm_chk_meta *pblk_get_chunk_meta(struct pblk *pblk)
>   
>   	ret = nvm_get_chunk_meta(dev, ppa, geo->all_chunks, meta);
>   	if (ret) {
> -		kfree(meta);
> +		vfree(meta);
>   		return ERR_PTR(-EIO);
>   	}
>   
> 

Thanks Hans. Applied for 5.1.
diff mbox series

Patch

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 1ff165351180..1b5ff51faa63 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -141,7 +141,7 @@  struct nvm_chk_meta *pblk_get_chunk_meta(struct pblk *pblk)
 
 	ret = nvm_get_chunk_meta(dev, ppa, geo->all_chunks, meta);
 	if (ret) {
-		kfree(meta);
+		vfree(meta);
 		return ERR_PTR(-EIO);
 	}