| Message ID | 20190305135120.29284-5-igor.j.konopko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | lightnvm: bugfixes and improvements | expand |
> On 5 Mar 2019, at 14.51, Igor Konopko <igor.j.konopko@intel.com> wrote: > > In current pblk implementation of erase command there is a chance > that the sector bits are set to some random values for erase PPA. > This is unexpected situation, since erase shall be always chunk > aligned based on OCSSD 2.0 specification. This patch fixes that issue. > > Signed-off-by: Igor Konopko <igor.j.konopko@intel.com> > --- > drivers/lightnvm/pblk-map.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/lightnvm/pblk-map.c b/drivers/lightnvm/pblk-map.c > index 7fbc99b..5408e32 100644 > --- a/drivers/lightnvm/pblk-map.c > +++ b/drivers/lightnvm/pblk-map.c > @@ -162,6 +162,7 @@ int pblk_map_erase_rq(struct pblk *pblk, struct nvm_rq *rqd, > > *erase_ppa = ppa_list[i]; > erase_ppa->a.blk = e_line->id; > + erase_ppa->a.reserved = 0; > > spin_unlock(&e_line->lock); > > -- > 2.9.5 Looks good to me. Reviewed-by: Javier González <javier@javigon.com>
Looks good, Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com> On Tue, Mar 5, 2019 at 2:54 PM Igor Konopko <igor.j.konopko@intel.com> wrote: > > In current pblk implementation of erase command there is a chance > that the sector bits are set to some random values for erase PPA. > This is unexpected situation, since erase shall be always chunk > aligned based on OCSSD 2.0 specification. This patch fixes that issue. > > Signed-off-by: Igor Konopko <igor.j.konopko@intel.com> > --- > drivers/lightnvm/pblk-map.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/lightnvm/pblk-map.c b/drivers/lightnvm/pblk-map.c > index 7fbc99b..5408e32 100644 > --- a/drivers/lightnvm/pblk-map.c > +++ b/drivers/lightnvm/pblk-map.c > @@ -162,6 +162,7 @@ int pblk_map_erase_rq(struct pblk *pblk, struct nvm_rq *rqd, > > *erase_ppa = ppa_list[i]; > erase_ppa->a.blk = e_line->id; > + erase_ppa->a.reserved = 0; > > spin_unlock(&e_line->lock); > > -- > 2.9.5 >
diff --git a/drivers/lightnvm/pblk-map.c b/drivers/lightnvm/pblk-map.c index 7fbc99b..5408e32 100644 --- a/drivers/lightnvm/pblk-map.c +++ b/drivers/lightnvm/pblk-map.c @@ -162,6 +162,7 @@ int pblk_map_erase_rq(struct pblk *pblk, struct nvm_rq *rqd, *erase_ppa = ppa_list[i]; erase_ppa->a.blk = e_line->id; + erase_ppa->a.reserved = 0; spin_unlock(&e_line->lock);
In current pblk implementation of erase command there is a chance that the sector bits are set to some random values for erase PPA. This is unexpected situation, since erase shall be always chunk aligned based on OCSSD 2.0 specification. This patch fixes that issue. Signed-off-by: Igor Konopko <igor.j.konopko@intel.com> --- drivers/lightnvm/pblk-map.c | 1 + 1 file changed, 1 insertion(+)