diff mbox series

[BUGFIX,1/1] block, bfq: fix operator in BFQQ_TOTALLY_SEEKY

Message ID 20190622193803.33044-2-paolo.valente@linaro.org (mailing list archive)
State New, archived
Headers show
Series block, bfq: fix mistake causing violation of service guarantees | expand

Commit Message

Paolo Valente June 22, 2019, 7:38 p.m. UTC 
By mistake, there is a '&' instead of a '==' in the definition of the
macro BFQQ_TOTALLY_SEEKY. This commit replaces the wrong operator with
the correct one.

Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
---
 block/bfq-iosched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paolo Valente June 22, 2019, 8:42 p.m. UTC | #1 
Sorry, I forgot to mention the fixed commit. Making a V2 ...

> Il giorno 22 giu 2019, alle ore 21:38, Paolo Valente <paolo.valente@linaro.org> ha scritto:
> 
> By mistake, there is a '&' instead of a '==' in the definition of the
> macro BFQQ_TOTALLY_SEEKY. This commit replaces the wrong operator with
> the correct one.
> 
> Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index f8d430f88d25..f9269ae6da9c 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -240,7 +240,7 @@ static struct kmem_cache *bfq_pool;
>  * containing only random (seeky) I/O are prevented from being tagged
>  * as soft real-time.
>  */
> -#define BFQQ_TOTALLY_SEEKY(bfqq)	(bfqq->seek_history & -1)
> +#define BFQQ_TOTALLY_SEEKY(bfqq)	(bfqq->seek_history == -1)
> 
> /* Min number of samples required to perform peak-rate update */
> #define BFQ_RATE_MIN_SAMPLES	32
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index f8d430f88d25..f9269ae6da9c 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -240,7 +240,7 @@  static struct kmem_cache *bfq_pool;
  * containing only random (seeky) I/O are prevented from being tagged
  * as soft real-time.
  */
-#define BFQQ_TOTALLY_SEEKY(bfqq)	(bfqq->seek_history & -1)
+#define BFQQ_TOTALLY_SEEKY(bfqq)	(bfqq->seek_history == -1)
 
 /* Min number of samples required to perform peak-rate update */
 #define BFQ_RATE_MIN_SAMPLES	32