diff mbox series

[v2,2/4] null_blk: match the type of parameter nr_devices

Message ID 20190913220300.422869-3-andrealmeid@collabora.com (mailing list archive)
State New, archived
Headers show
Series null_blk: fixes around nr_devices and log improvements | expand

Commit Message

André Almeida Sept. 13, 2019, 10:02 p.m. UTC 
Since the variable nr_devices is an unsigned int, the module_param()
should also use this type. Change the type so they can match.

Signed-off-by: André Almeida <andrealmeid@collabora.com>
Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
---
Changes since v1:
- Add "Fixes" tag
---
 drivers/block/null_blk_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaitanya Kulkarni Sept. 13, 2019, 10:15 p.m. UTC | #1 
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 09/13/2019 03:04 PM, André Almeida wrote:
> Since the variable nr_devices is an unsigned int, the module_param()
> should also use this type. Change the type so they can match.
>
> Signed-off-by: André Almeida <andrealmeid@collabora.com>
> Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
> ---
> Changes since v1:
> - Add "Fixes" tag
> ---
>   drivers/block/null_blk_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
> index be32cb5ed339..5d20d65041bd 100644
> --- a/drivers/block/null_blk_main.c
> +++ b/drivers/block/null_blk_main.c
> @@ -142,7 +142,7 @@ module_param_named(bs, g_bs, int, 0444);
>   MODULE_PARM_DESC(bs, "Block size (in bytes)");
>
>   static unsigned int nr_devices = 1;
> -module_param(nr_devices, int, 0444);
> +module_param(nr_devices, uint, 0444);
>   MODULE_PARM_DESC(nr_devices, "Number of devices to register");
>
>   static bool g_blocking;
>
diff mbox series

Patch

diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
index be32cb5ed339..5d20d65041bd 100644
--- a/drivers/block/null_blk_main.c
+++ b/drivers/block/null_blk_main.c
@@ -142,7 +142,7 @@  module_param_named(bs, g_bs, int, 0444);
 MODULE_PARM_DESC(bs, "Block size (in bytes)");
 
 static unsigned int nr_devices = 1;
-module_param(nr_devices, int, 0444);
+module_param(nr_devices, uint, 0444);
 MODULE_PARM_DESC(nr_devices, "Number of devices to register");
 
 static bool g_blocking;