| Message ID | 20191219061423.3775-1-chaitanya.kulkarni@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: mark zone-mgmt bios with REQ_SYNC | expand |
On 2019/12/19 15:14, Chaitanya Kulkarni wrote: > This patch marks the zone-mgmt bios with REQ_SYNC flag. > > Suggested-by: Damien Le Moal <damien.lemoal@wdc.com> > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > --- > block/blk-zoned.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-zoned.c b/block/blk-zoned.c > index d00fcfd71dfe..05741c6f618b 100644 > --- a/block/blk-zoned.c > +++ b/block/blk-zoned.c > @@ -198,7 +198,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_opf op, > break; > } > > - bio->bi_opf = op; > + bio->bi_opf = op | REQ_SYNC; > bio->bi_iter.bi_sector = sector; > sector += zone_sectors; Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
On 12/19/19 2:14 PM, Chaitanya Kulkarni wrote: > This patch marks the zone-mgmt bios with REQ_SYNC flag. > > Suggested-by: Damien Le Moal <damien.lemoal@wdc.com> > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > --- Reviewed-by: Bob Liu <bob.liu@oracle.com> > block/blk-zoned.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-zoned.c b/block/blk-zoned.c > index d00fcfd71dfe..05741c6f618b 100644 > --- a/block/blk-zoned.c > +++ b/block/blk-zoned.c > @@ -198,7 +198,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_opf op, > break; > } > > - bio->bi_opf = op; > + bio->bi_opf = op | REQ_SYNC; > bio->bi_iter.bi_sector = sector; > sector += zone_sectors; > >
On 12/18/19 11:14 PM, Chaitanya Kulkarni wrote:
> This patch marks the zone-mgmt bios with REQ_SYNC flag.
This needs a much better commit message, you're not telling me
anything I can't see by reading the patch itself. A good commit
message contains the reason for the patch, there's no justification
right now.
Jens, I sent out a new version, can you please take a look and let me know if you are happy with the commit log ? On 12/19/2019 04:47 AM, Jens Axboe wrote: > On 12/18/19 11:14 PM, Chaitanya Kulkarni wrote: >> >This patch marks the zone-mgmt bios with REQ_SYNC flag. > This needs a much better commit message, you're not telling me > anything I can't see by reading the patch itself. A good commit > message contains the reason for the patch, there's no justification > right now. > > -- Jens Axboe -ck
diff --git a/block/blk-zoned.c b/block/blk-zoned.c index d00fcfd71dfe..05741c6f618b 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -198,7 +198,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_opf op, break; } - bio->bi_opf = op; + bio->bi_opf = op | REQ_SYNC; bio->bi_iter.bi_sector = sector; sector += zone_sectors;
This patch marks the zone-mgmt bios with REQ_SYNC flag. Suggested-by: Damien Le Moal <damien.lemoal@wdc.com> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> --- block/blk-zoned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)