[blktests,02/11] common/xfs: Create common helper to check for XFS support

Commit Message

Logan Gunthorpe Aug. 27, 2020, 7:49 p.m. UTC

Two nvme tests create and mount XFS filesystems and
check for mkfs.xfs.

They should also check for XFS support in the kernel so
create a common helper for this.

Signed-off-by: Logan Gunthorpe <[e-mail]>
---
 common/rc      |  8 ++++++++
 common/xfs     | 11 +++++++++++
 tests/nvme/012 |  3 ++-
 tests/nvme/013 |  3 ++-
 4 files changed, 23 insertions(+), 2 deletions(-)
 create mode 100644 common/xfs

Patch

diff --git a/common/rc b/common/rc
index 7f02103dc786..3dd1ab76f737 100644
--- a/common/rc
+++ b/common/rc
@@ -181,6 +181,14 @@  _have_tracepoint() {
 	return 0
 }
 
+_have_fs() {
+	modprobe "$1" >/dev/null 2>&1
+	if [[ ! -d "/sys/fs/$1" ]]; then
+		SKIP_REASON="kernel does not support filesystem $1"
+		return 1
+	fi
+}
+
 _test_dev_is_rotational() {
 	[[ $(cat "${TEST_DEV_SYSFS}/queue/rotational") -ne 0 ]]
 }
diff --git a/common/xfs b/common/xfs
new file mode 100644
index 000000000000..d1a603b8c7b5
--- /dev/null
+++ b/common/xfs
@@ -0,0 +1,11 @@ 
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2017 Omar Sandoval
+#
+# fio helper functions.
+
+. common/shellcheck
+
+_have_xfs() {
+	_have_fs xfs && _have_program mkfs.xfs
+}
diff --git a/tests/nvme/012 b/tests/nvme/012
index dc86ee647729..981e7779e21d 100755
--- a/tests/nvme/012
+++ b/tests/nvme/012
@@ -5,12 +5,13 @@ 
 # Test mkfs with data verification for block device backed ns.
 
 . tests/nvme/rc
+. common/xfs
 
 DESCRIPTION="run mkfs and data verification fio job on NVMeOF block device-backed ns"
 TIMED=1
 
 requires() {
-	_have_program nvme && _have_program mkfs.xfs && _have_program fio && \
+	_have_program nvme && _have_xfs && _have_program fio && \
 		_have_modules loop nvme-loop nvmet && _have_configfs
 }
 
diff --git a/tests/nvme/013 b/tests/nvme/013
index 0ed52926363a..228fab9ff02b 100755
--- a/tests/nvme/013
+++ b/tests/nvme/013
@@ -5,12 +5,13 @@ 
 # Test mkfs with data verification for file backed ns.
 
 . tests/nvme/rc
+. common/xfs
 
 DESCRIPTION="run mkfs and data verification fio job on NVMeOF file-backed ns"
 TIMED=1
 
 requires() {
-	_have_program nvme && _have_program mkfs.xfs && _have_fio && \
+	_have_program nvme && _have_xfs && _have_fio && \
 		_have_modules nvme-loop nvmet && _have_configfs
 }