| Message ID | 20210207190425.38107-9-chaitanya.kulkarni@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | use core page calls instead of kmaps | expand |
On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> No explanation in commit message? There isn't much explanation needed for this, but there should be at least one sentence. Likewise for the other patches. > fs/f2fs/verity.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c > index 44e057bdc416..ca019685a944 100644 > --- a/fs/f2fs/verity.c > +++ b/fs/f2fs/verity.c > @@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, > PAGE_SIZE - offset_in_page(pos)); > struct page *page; > void *fsdata; > - void *addr; > int res; > > res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0, > @@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, > if (res) > return res; > > - addr = kmap_atomic(page); > - memcpy(addr + offset_in_page(pos), buf, n); > - kunmap_atomic(addr); > + memcpy_to_page(page, offset_in_page(pos) buf, n); This is missing a comma between 'offset_in_page(pos)' and 'buf'. Otherwise the patches to fs/{ext4,f2fs}/verity.c look fine; thanks for doing this! - Eric
On 2/10/21 10:01, Eric Biggers wrote: > On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote: >> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > No explanation in commit message? There isn't much explanation needed for this, > but there should be at least one sentence. > > Likewise for the other patches. > Thanks Eric for your comment. Sent out minimal RFC, I'll add detail explanation also having original series in the tree helps.
diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c index 44e057bdc416..ca019685a944 100644 --- a/fs/f2fs/verity.c +++ b/fs/f2fs/verity.c @@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, PAGE_SIZE - offset_in_page(pos)); struct page *page; void *fsdata; - void *addr; int res; res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0, @@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, if (res) return res; - addr = kmap_atomic(page); - memcpy(addr + offset_in_page(pos), buf, n); - kunmap_atomic(addr); + memcpy_to_page(page, offset_in_page(pos) buf, n); res = pagecache_write_end(NULL, inode->i_mapping, pos, n, n, page, fsdata);
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> --- fs/f2fs/verity.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)