From patchwork Wed Jul 14 09:45:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 12376413 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88EACC07E9A for ; Wed, 14 Jul 2021 09:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73E5B61396 for ; Wed, 14 Jul 2021 09:37:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238906AbhGNJkN (ORCPT ); Wed, 14 Jul 2021 05:40:13 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:11413 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238860AbhGNJkI (ORCPT ); Wed, 14 Jul 2021 05:40:08 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GPslB5QtfzccyK; Wed, 14 Jul 2021 17:33:58 +0800 (CST) Received: from dggema762-chm.china.huawei.com (10.1.198.204) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 14 Jul 2021 17:37:16 +0800 Received: from huawei.com (10.175.127.227) by dggema762-chm.china.huawei.com (10.1.198.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 14 Jul 2021 17:37:15 +0800 From: Yu Kuai To: , CC: , , , Subject: [PATCH 2/3] block, bfq: add support to record request size information Date: Wed, 14 Jul 2021 17:45:28 +0800 Message-ID: <20210714094529.758808-3-yukuai3@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210714094529.758808-1-yukuai3@huawei.com> References: <20210714094529.758808-1-yukuai3@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema762-chm.china.huawei.com (10.1.198.204) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org If bfq keep dispatching requests with same size, the following information are stored if CONFIG_BFQ_GROUP_IOSCHED is enabled: 1) the size 2) the count of requests 3) when the first request was dispatched These will be used in later patch to support concurrent sync io in such situation. Signed-off-by: Yu Kuai --- block/bfq-iosched.c | 15 +++++++++++++++ block/bfq-iosched.h | 16 ++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 2768a4c1cc45..e5a1093ec30a 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4920,6 +4920,20 @@ static bool bfq_has_work(struct blk_mq_hw_ctx *hctx) bfq_tot_busy_queues(bfqd) > 0; } +static void bfq_update_dispatch_size_info(struct bfq_data *bfqd, + unsigned int size) +{ +#ifdef CONFIG_BFQ_GROUP_IOSCHED + if (bfqd->dispatch_size == size) { + bfqd->dispatch_count++; + } else { + bfqd->dispatch_size = size; + bfqd->dispatch_count = 1; + bfqd->dispatch_time = jiffies; + } +#endif +} + static struct request *__bfq_dispatch_request(struct blk_mq_hw_ctx *hctx) { struct bfq_data *bfqd = hctx->queue->elevator->elevator_data; @@ -5003,6 +5017,7 @@ static struct request *__bfq_dispatch_request(struct blk_mq_hw_ctx *hctx) bfqd->rq_in_driver++; start_rq: rq->rq_flags |= RQF_STARTED; + bfq_update_dispatch_size_info(bfqd, blk_rq_bytes(rq)); } exit: return rq; diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 99c2a3cb081e..4b9d95447a50 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -768,6 +768,22 @@ struct bfq_data { * function) */ unsigned int word_depths[2][2]; + +#ifdef CONFIG_BFQ_GROUP_IOSCHED + /* the size of last dispatched request */ + unsigned int dispatch_size; + /* + * If bfq keep dispatching requests with same size, this store the + * count of requests. We use unsigned long here, so we don't care + * about overflow. + */ + unsigned long dispatch_count; + /* + * If bfq keep dispatching requests with same size, this store the + * time when the first request was dispatched. + */ + unsigned long dispatch_time; +#endif }; enum bfqq_state_flags {