From patchwork Sat Jul 17 12:33:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Natalenko X-Patchwork-Id: 12383587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30222C636CA for ; Sat, 17 Jul 2021 12:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05DE5613D8 for ; Sat, 17 Jul 2021 12:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233382AbhGQMgc (ORCPT ); Sat, 17 Jul 2021 08:36:32 -0400 Received: from vulcan.natalenko.name ([104.207.131.136]:55452 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhGQMgc (ORCPT ); Sat, 17 Jul 2021 08:36:32 -0400 Received: from localhost (unknown [151.237.229.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id B5A55B3A131; Sat, 17 Jul 2021 14:33:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1626525214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SD0R3zYxm1t/0uzxERpXDObXCsoS886xQ4oYuK4JvFQ=; b=TUdwv1Is81UuNOHvc02lrew+ITkwqXP258zdpyM4UJqjxEHo4fA/hKv987fsuqcH7uLXnf Yn36cuzPlVPYF2CFI2L1Ty74q3GF6NOBM6h4D2rZ6lQqURI6rPGFohtmUqTZoSwkwS6emy n1Hl3sVJJ/Nejvs/bMgtTAYmzEg76KM= From: Oleksandr Natalenko To: linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Jens Axboe , Ming Lei , Christoph Hellwig , Laurence Oberman , Paolo Valente , David Jeffery , Bart Van Assche Subject: [PATCH] block: increase BLKCG_MAX_POLS Date: Sat, 17 Jul 2021 14:33:28 +0200 Message-Id: <20210717123328.945810-1-oleksandr@natalenko.name> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org After mq-deadline learnt to deal with cgroups, the BLKCG_MAX_POLS value became too small for all the elevators to be registered properly. The following issue is seen: ``` calling bfq_init+0x0/0x8b @ 1 blkcg_policy_register: BLKCG_MAX_POLS too small initcall bfq_init+0x0/0x8b returned -28 after 507 usecs ``` and BFQ is non-functional. Increase BLKCG_MAX_POLS to allow space for everyone Link: https://lore.kernel.org/lkml/8988303.mDXGIdCtx8@natalenko.name/ Signed-off-by: Oleksandr Natalenko --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 3177181c4326..d3afea47ade6 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -57,7 +57,7 @@ struct blk_keyslot_manager; * Maximum number of blkcg policies allowed to be registered concurrently. * Defined here to simplify include dependency. */ -#define BLKCG_MAX_POLS 5 +#define BLKCG_MAX_POLS 6 typedef void (rq_end_io_fn)(struct request *, blk_status_t);