diff mbox series

[2/2] nbd: fix possible overflow for 'first_minor' in nbd_dev_add()

Message ID 20211021122936.758221-3-yukuai3@huawei.com (mailing list archive)
State New, archived
Headers show
Series nbd: fix sanity check for first_minor | expand

Commit Message

Yu Kuai Oct. 21, 2021, 12:29 p.m. UTC 
If 'part_shift' is not zero, then 'index << part_shift' might
overflow to a value that is not greater than '0xfffff', then sysfs
might complains about duplicate creation.

Fixes: b0d9111a2d53 ("nbd: use an idr to keep track of nbd devices")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/block/nbd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 8f2c17a33c5b..03a10a87500d 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1808,11 +1808,11 @@  static struct nbd_device *nbd_dev_add(int index, unsigned int refs)
 	disk->major = NBD_MAJOR;
 
 	/* Too big first_minor can cause duplicate creation of
-	 * sysfs files/links, since MKDEV() expect that the max bits of
-	 * first_minor is 20.
+	 * sysfs files/links, since index << part_shift might overflow, or
+	 * MKDEV() expect that the max bits of first_minor is 20.
 	 */
 	disk->first_minor = index << part_shift;
-	if (disk->first_minor > 0xfffff) {
+	if (disk->first_minor < index || disk->first_minor > 0xfffff) {
 		err = -EINVAL;
 		goto out_free_idr;
 	}