From patchwork Sat Nov 6 18:55:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 12606513 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA110C433F5 for ; Sat, 6 Nov 2021 18:55:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDFC7611C0 for ; Sat, 6 Nov 2021 18:55:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234018AbhKFS6i (ORCPT ); Sat, 6 Nov 2021 14:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhKFS6i (ORCPT ); Sat, 6 Nov 2021 14:58:38 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C6EAC061714 for ; Sat, 6 Nov 2021 11:55:56 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:91c6:551:e507:741f]) by andre.telenet-ops.be with bizsmtp id F6vr2600C4BJ5g4016vrgE; Sat, 06 Nov 2021 19:55:54 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mjQr1-00AdOS-Fg; Sat, 06 Nov 2021 19:55:51 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1mjQr0-006cdY-Si; Sat, 06 Nov 2021 19:55:50 +0100 From: Geert Uytterhoeven To: Jens Axboe , Luis Chamberlain Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , noreply@ellerman.id.au Subject: [PATCH -next] ataflop: Add missing semicolon to return statement Date: Sat, 6 Nov 2021 19:55:49 +0100 Message-Id: <20211106185549.1578444-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org drivers/block/ataflop.c: In function ‘ataflop_probe’: drivers/block/ataflop.c:2023:2: error: expected expression before ‘if’ 2023 | if (ataflop_alloc_disk(drive, type)) | ^~ drivers/block/ataflop.c:2023:2: error: ‘return’ with a value, in function returning void [-Werror=return-type] drivers/block/ataflop.c:2011:13: note: declared here 2011 | static void ataflop_probe(dev_t dev) | ^~~~~~~~~~~~~ Fixes: 46a7db492e7a2740 ("ataflop: address add_disk() error handling on probe") Reported-by: noreply@ellerman.id.au Signed-off-by: Geert Uytterhoeven --- Feel free to fold into the commit that introduced the issue. --- drivers/block/ataflop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c index de8c3785899a5de3..bf769e6e32fef92b 100644 --- a/drivers/block/ataflop.c +++ b/drivers/block/ataflop.c @@ -2019,7 +2019,7 @@ static void ataflop_probe(dev_t dev) if (drive >= FD_MAX_UNITS || type >= NUM_DISK_MINORS) return; if (unit[drive].disk[type]) - return + return; if (ataflop_alloc_disk(drive, type)) return; if (add_disk(unit[drive].disk[type]))