| Message ID | 20220113001432.1331871-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | loop: remove redundant initialization of pointer node | expand |
On Thu, 13 Jan 2022 00:14:32 +0000, Colin Ian King wrote: > The pointer node is being initialized with a value that is never > read, it is being re-assigned the same value a little futher on. > Remove the redundant initialization. Cleans up clang scan warning: > > drivers/block/loop.c:823:19: warning: Value stored to 'node' during > its initialization is never read [deadcode.DeadStores] > > [...] Applied, thanks! [1/1] loop: remove redundant initialization of pointer node commit: 413ec8057bc3d368574abd05dd27e747063b2f59 Best regards,
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index b1b05c45c07c..01cbbfc4e9e2 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -820,7 +820,7 @@ static inline int queue_on_root_worker(struct cgroup_subsys_state *css) static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) { - struct rb_node **node = &(lo->worker_tree.rb_node), *parent = NULL; + struct rb_node **node, *parent = NULL; struct loop_worker *cur_worker, *worker = NULL; struct work_struct *work; struct list_head *cmd_list;
The pointer node is being initialized with a value that is never read, it is being re-assigned the same value a little futher on. Remove the redundant initialization. Cleans up clang scan warning: drivers/block/loop.c:823:19: warning: Value stored to 'node' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)