| Message ID | 20220207074931.20067-1-song.bao.hua@hisilicon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | docs: block: biodoc.rst: Drop the obsolete and incorrect content | expand |
I suspect it is timeto just drop that entire file. It is so stale that it is actively harmful.
On 2/9/22 1:32 AM, Christoph Hellwig wrote: > I suspect it is timeto just drop that entire file. It is so stale > that it is actively harmful. I'll apply this one since it's obviously correct, but yes, we probably should just kill this file.
On Mon, 7 Feb 2022 15:49:31 +0800, Barry Song wrote: > Since commit 7eaceaccab5f ("block: remove per-queue plugging"), kernel > has removed blk_run_address_space(), blk_unplug() and sync_buffer(), > and moved to on-stack plugging. The document has been obsolete for > years. > Given that there is no obvious counterparts in the new mechinism to > replace old APIs, this patch drops the content directly. > > [...] Applied, thanks! [1/1] docs: block: biodoc.rst: Drop the obsolete and incorrect content commit: 2e2f0199a20780463945e1cbffb3a191fa84bd9d Best regards,
diff --git a/Documentation/block/biodoc.rst b/Documentation/block/biodoc.rst index 2098477851a4..9df0c9cf6090 100644 --- a/Documentation/block/biodoc.rst +++ b/Documentation/block/biodoc.rst @@ -970,11 +970,7 @@ till it fills up with a few more requests, before starting to service the requests. This provides an opportunity to merge/sort the requests before passing them down to the device. There are various conditions when the queue is unplugged (to open up the flow again), either through a scheduled task or -could be on demand. For example wait_on_buffer sets the unplugging going -through sync_buffer() running blk_run_address_space(mapping). Or the caller -can do it explicity through blk_unplug(bdev). So in the read case, -the queue gets explicitly unplugged as part of waiting for completion on that -buffer. +could be on demand. Aside: This is kind of controversial territory, as it's not clear if plugging is
Since commit 7eaceaccab5f ("block: remove per-queue plugging"), kernel has removed blk_run_address_space(), blk_unplug() and sync_buffer(), and moved to on-stack plugging. The document has been obsolete for years. Given that there is no obvious counterparts in the new mechinism to replace old APIs, this patch drops the content directly. Signed-off-by: Barry Song <song.bao.hua@hisilicon.com> --- Documentation/block/biodoc.rst | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)