diff mbox series

n64cart: convert bi_disk to bi_bdev->bd_disk fix build

Message ID 20220321071216.1549596-1-liu.yun@linux.dev (mailing list archive)
State New, archived
Headers show
Series n64cart: convert bi_disk to bi_bdev->bd_disk fix build | expand

Commit Message

Jackie Liu March 21, 2022, 7:12 a.m. UTC 
From: Jackie Liu <liuyun01@kylinos.cn>

My kernel robot report below:

  drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
  drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
     91 |  struct device *dev = bio->bi_disk->private_data;
        |                          ^~
    CC      drivers/slimbus/qcom-ctrl.o
    CC      drivers/auxdisplay/hd44780.o
    CC      drivers/watchdog/watchdog_core.o
    CC      drivers/nvme/host/fault_inject.o
    AR      drivers/accessibility/braille/built-in.a
  make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1

Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio");
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
 drivers/block/n64cart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaitanya Kulkarni March 21, 2022, 7:22 a.m. UTC | #1 
On 3/21/22 00:12, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
> 
> My kernel robot report below:
> 
>    drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
>    drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
>       91 |  struct device *dev = bio->bi_disk->private_data;
>          |                          ^~
>      CC      drivers/slimbus/qcom-ctrl.o
>      CC      drivers/auxdisplay/hd44780.o
>      CC      drivers/watchdog/watchdog_core.o
>      CC      drivers/nvme/host/fault_inject.o
>      AR      drivers/accessibility/braille/built-in.a
>    make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
> 
> Fixes: 309dca309fc3 ("block: store a block_device pointer in struct bio");
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Jens Axboe March 21, 2022, 12:35 p.m. UTC | #2 
On Mon, 21 Mar 2022 15:12:16 +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
> 
> My kernel robot report below:
> 
>   drivers/block/n64cart.c: In function ‘n64cart_submit_bio’:
>   drivers/block/n64cart.c:91:26: error: ‘struct bio’ has no member named ‘bi_disk’
>      91 |  struct device *dev = bio->bi_disk->private_data;
>         |                          ^~
>     CC      drivers/slimbus/qcom-ctrl.o
>     CC      drivers/auxdisplay/hd44780.o
>     CC      drivers/watchdog/watchdog_core.o
>     CC      drivers/nvme/host/fault_inject.o
>     AR      drivers/accessibility/braille/built-in.a
>   make[2]: *** [scripts/Makefile.build:288: drivers/block/n64cart.o] Error 1
> 
> [...]

Applied, thanks!

[1/1] n64cart: convert bi_disk to bi_bdev->bd_disk fix build
      commit: b2479de38d8fc7ef13d5c78ff5ded6e5a1a4eac0

Best regards,
diff mbox series

Patch

diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index 4db9a8c244af..e094d2b8b5a9 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -88,7 +88,7 @@  static void n64cart_submit_bio(struct bio *bio)
 {
 	struct bio_vec bvec;
 	struct bvec_iter iter;
-	struct device *dev = bio->bi_disk->private_data;
+	struct device *dev = bio->bi_bdev->bd_disk->private_data;
 	u32 pos = bio->bi_iter.bi_sector << SECTOR_SHIFT;
 
 	bio_for_each_segment(bvec, bio, iter) {