diff mbox series

[3/3] drbd: set QUEUE_FLAG_STABLE_WRITES

Message ID 20220406190445.1937206-4-christoph.boehmwalder@linbit.com (mailing list archive)
State New, archived
Headers show
Series DRBD fixes for Linux 5.18 | expand

Commit Message

Christoph Böhmwalder April 6, 2022, 7:04 p.m. UTC 
From: Christoph Böhmwalder <christoph@boehmwalder.at>

We want our pages not to change while they are being written.

Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
 drivers/block/drbd/drbd_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig April 7, 2022, 6:15 a.m. UTC | #1 
On Wed, Apr 06, 2022 at 09:04:45PM +0200, Christoph Böhmwalder wrote:
> From: Christoph Böhmwalder <christoph@boehmwalder.at>
> 
> We want our pages not to change while they are being written.

Please document the _why_.  A commit like that will leave everyone
looking at this code in the future rather puzzled.
diff mbox series

Patch

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index d6dfa286ddb3..4b0b25cc916e 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -2719,6 +2719,7 @@  enum drbd_ret_code drbd_create_device(struct drbd_config_context *adm_ctx, unsig
 	sprintf(disk->disk_name, "drbd%d", minor);
 	disk->private_data = device;
 
+	blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, disk->queue);
 	blk_queue_write_cache(disk->queue, true, true);
 	/* Setting the max_hw_sectors to an odd value of 8kibyte here
 	   This triggers a max_bio_size message upon first attach or connect */