| Message ID | 20220602075159.1273366-1-damien.lemoal@opensource.wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: remove useless BUG_ON() in blk_mq_put_tag() | expand |
On Thu, 2 Jun 2022 16:51:59 +0900, Damien Le Moal wrote: > Since the if condition in blk_mq_put_tag() checks that the tag to put is > not a reserved one, the BUG_ON() check in the else branch checking if > the tag is indeed a reserved one is useless. Remove it. > > Applied, thanks! [1/1] block: remove useless BUG_ON() in blk_mq_put_tag() commit: ff47dbd18b8db251fe1fd013a8fa067d381ecd5b Best regards,
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index 68ac23d0b640..2dcd738c6952 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -228,7 +228,6 @@ void blk_mq_put_tag(struct blk_mq_tags *tags, struct blk_mq_ctx *ctx, BUG_ON(real_tag >= tags->nr_tags); sbitmap_queue_clear(&tags->bitmap_tags, real_tag, ctx->cpu); } else { - BUG_ON(tag >= tags->nr_reserved_tags); sbitmap_queue_clear(&tags->breserved_tags, tag, ctx->cpu); } }
Since the if condition in blk_mq_put_tag() checks that the tag to put is not a reserved one, the BUG_ON() check in the else branch checking if the tag is indeed a reserved one is useless. Remove it. Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> --- block/blk-mq-tag.c | 1 - 1 file changed, 1 deletion(-)