| Message ID | 20220616041214.612087-1-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] check: ensure to suppress job status output | expand |
On Thu 16-06-22 13:12:14, Shin'ichiro Kawasaki wrote: > Unexpected job status output by wait commands was observed on openSUSE > 15.3 and it made some test cases fail. To avoid the job status output > during test case runs, ensure to turn off job control monitor in sub- > shell for test case runs. > > Reported-by: Jan Kara <jack@suse.cz> > Link: https://lore.kernel.org/linux-block/20220613151721.18664-1-jack@suse.cz/ > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Thanks! Feel free to add: Tested-by: Jan Kara <jack@suse.cz> Honza > --- > check | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/check b/check > index 7037d88..a0c27d9 100755 > --- a/check > +++ b/check > @@ -440,6 +440,10 @@ _run_test() { > RUN_FOR_ZONED=0 > FALLBACK_DEVICE=0 > > + # Ensure job control monitor mode is off in the sub-shell for test case > + # runs to suppress job status output. > + set +m > + > # shellcheck disable=SC1090 > . "tests/${TEST_NAME}" > > -- > 2.36.1 >
On 6/15/2022 9:12 PM, Shin'ichiro Kawasaki wrote: > Unexpected job status output by wait commands was observed on openSUSE > 15.3 and it made some test cases fail. To avoid the job status output > during test case runs, ensure to turn off job control monitor in sub- > shell for test case runs. > > Reported-by: Jan Kara <jack@suse.cz> > Link: https://lore.kernel.org/linux-block/20220613151721.18664-1-jack@suse.cz/ > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
On Jun 16, 2022 / 13:12, Shin'ichiro Kawasaki wrote: > Unexpected job status output by wait commands was observed on openSUSE > 15.3 and it made some test cases fail. To avoid the job status output > during test case runs, ensure to turn off job control monitor in sub- > shell for test case runs. > > Reported-by: Jan Kara <jack@suse.cz> > Link: https://lore.kernel.org/linux-block/20220613151721.18664-1-jack@suse.cz/ > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Thanks for the tags. Applied.
diff --git a/check b/check index 7037d88..a0c27d9 100755 --- a/check +++ b/check @@ -440,6 +440,10 @@ _run_test() { RUN_FOR_ZONED=0 FALLBACK_DEVICE=0 + # Ensure job control monitor mode is off in the sub-shell for test case + # runs to suppress job status output. + set +m + # shellcheck disable=SC1090 . "tests/${TEST_NAME}"
Unexpected job status output by wait commands was observed on openSUSE 15.3 and it made some test cases fail. To avoid the job status output during test case runs, ensure to turn off job control monitor in sub- shell for test case runs. Reported-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/linux-block/20220613151721.18664-1-jack@suse.cz/ Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- check | 4 ++++ 1 file changed, 4 insertions(+)