| Message ID | 20220729001505.1489933-1-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] nvme/040: fix write file path | expand |
On 7/28/22 17:15, Shin'ichiro Kawasaki wrote: > The test case nvme/040 performs I/O to a nvmf device file. However, it > specifies wrong path to the device file then the I/O is done to a > regular file. Hence fix the path. > > Fixes: ebf197d1aea4 ("nvme: add nvmf reset/disconnect during traffic test") > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> > --- Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
On Aug 04, 2022 / 06:47, Chaitanya Kulkarni wrote: > On 7/28/22 17:15, Shin'ichiro Kawasaki wrote: > > The test case nvme/040 performs I/O to a nvmf device file. However, it > > specifies wrong path to the device file then the I/O is done to a > > regular file. Hence fix the path. > > > > Fixes: ebf197d1aea4 ("nvme: add nvmf reset/disconnect during traffic test") > > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> > > --- > > Looks good. > > Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Thanks for the review. I've applied this with an amendment in the commit title.
diff --git a/tests/nvme/040 b/tests/nvme/040 index 10c1815..04bd726 100755 --- a/tests/nvme/040 +++ b/tests/nvme/040 @@ -37,7 +37,7 @@ test() { # start fio job echo "starting background fio" - _run_fio_rand_io --filename="${nvmedev}n1" --size=1g \ + _run_fio_rand_io --filename="/dev/${nvmedev}n1" --size=1g \ --group_reporting --ramp_time=5 &> /dev/null & sleep 5
The test case nvme/040 performs I/O to a nvmf device file. However, it specifies wrong path to the device file then the I/O is done to a regular file. Hence fix the path. Fixes: ebf197d1aea4 ("nvme: add nvmf reset/disconnect during traffic test") Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- tests/nvme/040 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)