| Message ID | 20220818012624.71544-7-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fix module check issues | expand |
On 8/17/22 18:26, Shin'ichiro Kawasaki wrote: > + required_drivers=( > + sd_mod > + sg > + ) > + _have_drivers "${required_drivers[@]}" Can the above be simplified into _have_drivers sd_mod sg? Thanks, Bart.
On Aug 18, 2022 / 13:07, Bart Van Assche wrote: > On 8/17/22 18:26, Shin'ichiro Kawasaki wrote: > > + required_drivers=( > > + sd_mod > > + sg > > + ) > > + _have_drivers "${required_drivers[@]}" > > Can the above be simplified into _have_drivers sd_mod sg? Sure, will do so in v3.
diff --git a/tests/srp/rc b/tests/srp/rc index 94ee97c..46c75c6 100755 --- a/tests/srp/rc +++ b/tests/srp/rc @@ -28,13 +28,18 @@ is_lio_configured() { } group_requires() { - local m name p required_modules + local m name p required_drivers required_modules _have_configfs || return if is_lio_configured; then SKIP_REASONS+=("LIO must be unloaded before the SRP tests are run") return fi + required_drivers=( + sd_mod + sg + ) + _have_drivers "${required_drivers[@]}" required_modules=( dm_multipath dm_queue_length @@ -51,9 +56,6 @@ group_requires() { scsi_dh_alua scsi_dh_emc scsi_dh_rdac - sd_mod - sd_mod - sg target_core_iblock target_core_mod )
The srp test group can be executed with built-in sd_mod and sg drivers. Check the drivers with _have_drivers() in place of _have_modules. Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> --- tests/srp/rc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)