| Message ID | 20220823121859.163903-9-p.raghav@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v12,01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size | expand |
On 8/23/22 05:18, Pankaj Raghav wrote: > From: Luis Chamberlain <mcgrof@kernel.org> > > dm-zoned relies on the assumption that the zone size is a > power-of-2(po2) and the zone capacity is same as the zone size. > > Ensure only po2 devices can be used as dm-zoned target until a native > support for zoned devices with non-po2 zone size is added. Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On Tue, Aug 23 2022 at 8:18P -0400, Pankaj Raghav <p.raghav@samsung.com> wrote: > From: Luis Chamberlain <mcgrof@kernel.org> > > dm-zoned relies on the assumption that the zone size is a > power-of-2(po2) and the zone capacity is same as the zone size. > > Ensure only po2 devices can be used as dm-zoned target until a native > support for zoned devices with non-po2 zone size is added. > > Reviewed-by: Hannes Reinecke <hare@suse.de> > Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> Reviewed-by: Mike Snitzer <snitzer@kernel.org>
diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c index 95b132b52f33..9325bf5dee81 100644 --- a/drivers/md/dm-zoned-target.c +++ b/drivers/md/dm-zoned-target.c @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti) return -EINVAL; } zone_nr_sectors = bdev_zone_sectors(bdev); + if (!is_power_of_2(zone_nr_sectors)) { + ti->error = "Zone size is not a power-of-2 number of sectors"; + return -EINVAL; + } zoned_dev->zone_nr_sectors = zone_nr_sectors; zoned_dev->nr_zones = bdev_nr_zones(bdev); } @@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti) return -EINVAL; } zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev); + if (!is_power_of_2(zoned_dev->zone_nr_sectors)) { + ti->error = "Zone size is not a power-of-2 number of sectors"; + return -EINVAL; + } zoned_dev->nr_zones = bdev_nr_zones(bdev); }