diff mbox series

[3/3] rnbd-srv: remove redundant setting of blk_open_flags

Message ID 20220830123904.26671-4-guoqing.jiang@linux.dev (mailing list archive)
State New, archived
Headers show
Series Small changes for rnbd-srv | expand

Commit Message

Guoqing Jiang Aug. 30, 2022, 12:39 p.m. UTC 
It is not necessary since it is set later just before function
return success.

Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
 drivers/block/rnbd/rnbd-srv-dev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Chaitanya Kulkarni Aug. 30, 2022, 1:01 p.m. UTC | #1 
On 8/30/22 05:39, Guoqing Jiang wrote:
> It is not necessary since it is set later just before function
> return success.
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Haris Iqbal Aug. 30, 2022, 1:30 p.m. UTC | #2 
On Tue, Aug 30, 2022 at 3:02 PM Chaitanya Kulkarni
<chaitanyak@nvidia.com> wrote:
>
> On 8/30/22 05:39, Guoqing Jiang wrote:
> > It is not necessary since it is set later just before function
> > return success.
> >
> > Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> > ---
>
>
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

This looks good,

Acked-by: Md Haris Iqbal <haris.iqbal@ionos.com>

>
>
diff mbox series

Patch

diff --git a/drivers/block/rnbd/rnbd-srv-dev.c b/drivers/block/rnbd/rnbd-srv-dev.c
index c63017f6e421..38131fa5718d 100644
--- a/drivers/block/rnbd/rnbd-srv-dev.c
+++ b/drivers/block/rnbd/rnbd-srv-dev.c
@@ -21,7 +21,6 @@  struct rnbd_dev *rnbd_dev_open(const char *path, fmode_t flags)
 	if (!dev)
 		return ERR_PTR(-ENOMEM);
 
-	dev->blk_open_flags = flags;
 	dev->bdev = blkdev_get_by_path(path, flags, THIS_MODULE);
 	ret = PTR_ERR_OR_ZERO(dev->bdev);
 	if (ret)