| Message ID | 20220926092241.1191846-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] block/swim3: add __init annotation to module init func | expand |
Le 26/09/2022 à 11:22, ruanjinjie a écrit : > Add missing __init annotation to module init func. > > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> > --- > drivers/block/swim3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c > index da811a7da03f..1f65d506fbc9 100644 > --- a/drivers/block/swim3.c > +++ b/drivers/block/swim3.c > @@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver = > }; > > > -int swim3_init(void) > +int __init swim3_init(void) > { > macio_register_driver(&swim3_driver); > return 0; Hi, unrelated, but should there be a swim3_exit() to call macio_register_driver(), as already done in some other drivers using these functions? CJ
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c index da811a7da03f..1f65d506fbc9 100644 --- a/drivers/block/swim3.c +++ b/drivers/block/swim3.c @@ -1278,7 +1278,7 @@ static struct macio_driver swim3_driver = }; -int swim3_init(void) +int __init swim3_init(void) { macio_register_driver(&swim3_driver); return 0;
Add missing __init annotation to module init func. Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> --- drivers/block/swim3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)