From patchwork Mon Nov 7 00:50:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 13033716 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68143C4321E for ; Mon, 7 Nov 2022 00:50:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbiKGAuo (ORCPT ); Sun, 6 Nov 2022 19:50:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230119AbiKGAuj (ORCPT ); Sun, 6 Nov 2022 19:50:39 -0500 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBDB4C759 for ; Sun, 6 Nov 2022 16:50:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1667782233; x=1699318233; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sJYwO2YFLt4950BGsnhd04xfiHD38rnFysO3T/X3rW4=; b=jFeAeGZK4eSF4uWY235FHaE1Fyz7I1U9unZH5n7BayzbdIieDj3aYcUW RtAHBjcEYwMHj08ULOdVd4ttsq/fyeszh6LRvaGft2oSj5f4cw0FUGWwE DlkyOa3TPDcKBQ4q/YgUyhC5FMbaFaj9rOhKm9JttWjhNoDFraPTiHpoP cqLP7JP8VMulhMprGmkO+plEOw3i9tOY3HLkH5BcS+9DCabnUdHMNx8G1 8IdZShV+Cp0JQJalf+yY/PxLe8W6azegSPPnJZS02XAe41Q7iqooFjYqH hgpSZ0WYLz2RzVc4QLUC0jgcjr2HqsRP7UUeFZPgsO4ft6a5zazR0uoH5 g==; X-IronPort-AV: E=Sophos;i="5.96,143,1665417600"; d="scan'208";a="215958492" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 07 Nov 2022 08:50:33 +0800 IronPort-SDR: 1V00CRFP/9096Q4ePZVcaK+Pfi08M8K+QRmF1fWR6nvDSlfO6PYoJk8jy5JkCLFfqEE7zmllt2 112de8bOSFZCMpxz2c6jxQVjiZGh5sSqsdyF5UoAThZKQ1jokJ8ePIGlMANZ8EI0L1NyML/4b8 LwJ4WEEgVB2Ph0WwQ1Ndw30nQhprX91AzC7gq5mipxbaddTx/k1otowS3CTLz0I5aBvYwsCMW6 GDVquDKWr2huUdl9f4hn/1ZIH/toJ0z+RUm4BfdfyfgOT7eprXwnvI5zTIDi/KPAyKkF5qeMjR njg= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Nov 2022 16:09:41 -0800 IronPort-SDR: Dtx3bR5dTLGyUdzhG4AuzrR1cu8dhIvyiX8DcLwnAjWgO7ZLO+TufoOBsH9khMm4TQgt2qEqsf Fyqvi5yRt4Dd0ihwS7FbDYhjWsM81YaZAl1xRLzZyxZW/kZC/Os9oHir9cVuTmRsspN1Yzu2a7 eITHD1mbxWsO2nPIe3h+LOfX+MoazNelVEViQG0fa2PXe+NOvuNfSy5UccQr5LOgD8XH2ZV9g7 0OQlewi8ow7DRNmnAmgsVQrXJ+lYbOXhlr39M8JAVPzE5+3WdgjA2lmrgYRwmMOsVQBh9CYtEj OsE= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Nov 2022 16:50:34 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4N5CMD3fzrz1RwtC for ; Sun, 6 Nov 2022 16:50:32 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:mime-version :references:in-reply-to:x-mailer:message-id:date:subject:to :from; s=dkim; t=1667782231; x=1670374232; bh=sJYwO2YFLt4950BGsn hd04xfiHD38rnFysO3T/X3rW4=; b=ZsS6mpUyPxvThlR659m6Oi6780OUpp5tGn KFFs5z2fljlimQLwMi0kqCBSN9fZJvO0mM2lHIWsWnsBnhZeliRHkLcRfA+B17bh A+8ule6deIPoLPYCwueVAoOWe6c2IgGgKFaVU/bbPkzJFf6gP2UiIiy5gaJASTRB aw5ivMIcdMdyYkdKMmv8ijzH5U/f5je39JdWarwPminIzY6r3dmtlj4Kg2hGIigA i4aryZG16lfvIyXsQFkXVmXXXCMaUrB9GZS9P32BL4HClXLO26k7FLAexrC+AaAO n/K/KMTYmK0/5V4F5z2fv9HI9bXyHmHtLKV6XWl0LH+qAWRlhytQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id lbhX0RnMlA4X for ; Sun, 6 Nov 2022 16:50:31 -0800 (PST) Received: from washi.fujisawa.hgst.com (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4N5CMB65D2z1RvLy; Sun, 6 Nov 2022 16:50:30 -0800 (PST) From: Damien Le Moal To: linux-ide@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe Cc: "Maciej S . Szmigiero" , Hannes Reinecke , Christoph Hellwig Subject: [PATCH v5 6/7] ata: libata: blacklist FUA support for known buggy drives Date: Mon, 7 Nov 2022 09:50:20 +0900 Message-Id: <20221107005021.1327692-7-damien.lemoal@opensource.wdc.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221107005021.1327692-1-damien.lemoal@opensource.wdc.com> References: <20221107005021.1327692-1-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Thread [1] reported back in 2012 problems with enabling FUA for 3 different drives. Add these drives to ata_device_blacklist[] to mark them with the ATA_HORKAGE_NO_FUA flag. To be conservative and avoid problems on old systems, the model number for the three new entries are defined as to widely match all drives in the same product line. [1]: https://lore.kernel.org/lkml/CA+6av4=uxu_q5U_46HtpUt=FSgbh3pZuAEY54J5_xK=MKWq-YQ@mail.gmail.com/ Suggested-by: Maciej S. Szmigiero Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: Maciej S. Szmigiero Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig --- drivers/ata/libata-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 83bea8591b08..29042665c550 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4137,6 +4137,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { /* Buggy FUA */ { "Maxtor", "BANC1G10", ATA_HORKAGE_NO_FUA }, + { "WDC*WD2500J*", NULL, ATA_HORKAGE_NO_FUA }, + { "OCZ-VERTEX*", NULL, ATA_HORKAGE_NO_FUA }, + { "INTEL*SSDSC2CT*", NULL, ATA_HORKAGE_NO_FUA }, /* End Marker */ { }