From patchwork Fri Dec 9 09:44:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 13069406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA665C4167B for ; Fri, 9 Dec 2022 09:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229892AbiLIJoy (ORCPT ); Fri, 9 Dec 2022 04:44:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiLIJox (ORCPT ); Fri, 9 Dec 2022 04:44:53 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C145F6F4 for ; Fri, 9 Dec 2022 01:44:51 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id vp12so10196760ejc.8 for ; Fri, 09 Dec 2022 01:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H138aqobhHjmcHH6RFqFD59W1hrmC7/KCJez2I0jafo=; b=btsU6l53eY4vFTX9AKDdy2g9od1LLpdLdDuu1QCPF/k7IGTTEemCejPLwajzETQFOM rHSM4wnGbVop+UajdwrT/guv2ol9KtEfORylRr+hxwkiQnVNvBx+7LMBBg3KGjQbf11o 9f9nHHpTXziUIugVTOV14V58b7lRvIhMWGQti3p+PROjNvzcqtbqT1Bp7hIH7y9zhnZ1 tyJm3f2OgsfG42zlttZeAGz/0UdT3NcR9ljWDRl/9t5ZQPSNum9HsWM9DR8C/dEHNtVR eunCVoF7iRT8Ke4TBTKkXZCV2B0wcmKLkXbqmZrp1D2EiNVfAble4f6sHizgGQ27PaPD Qaag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H138aqobhHjmcHH6RFqFD59W1hrmC7/KCJez2I0jafo=; b=oB71d4MAPT6ekAsuSTd3L3rkM2FkkkOLE2jf/I/Pifhn9OVfY3p56LWkXgRBj9I1MA wOheS62OeCU2NMCRZAqtlQYLlgs+wd6khNc8JiWY31bid6/IRWJC5jlT1wjA30sAh8Tk rlxucIuKaFgADTtIuNkCHOCwIfVZMc15eadoTSRudPB1b1PLEHvjjPautSIkZ0qKdG2g gsScfVka0eXKgiGYItuC2ABBRu7B0n28seD68deP8E5ai9OcoacHfSv0kQAbL4LNrN2t +VqqD4nNlt0bIVhCUUoPA05VEPs2nt9ioHKyBQ6r6AUPs53iPfuIxoOmEZSMBwW23i05 twzg== X-Gm-Message-State: ANoB5plLPghQnwZHvLfZ7gc0mvQ7AyS3jv76NFY9EfzQv7zv78GqTAWr e71vDHWEVfUTAiKIo7JkB+mohQ== X-Google-Smtp-Source: AA0mqf56YsryAxyHwHwpOu7+wWTQ89NirJxVuHzRZQds2YmCDTN7qwuW2baOR6DrPcHkXgWAYPsz8g== X-Received: by 2002:a17:907:a0cb:b0:7b9:c08b:e8a2 with SMTP id hw11-20020a170907a0cb00b007b9c08be8a2mr4665419ejc.15.1670579089983; Fri, 09 Dec 2022 01:44:49 -0800 (PST) Received: from MBP-di-Paolo.station (net-2-35-55-161.cust.vodafonedsl.it. [2.35.55.161]) by smtp.gmail.com with ESMTPSA id oz18-20020a170906cd1200b007c11f2a3b3dsm353421ejb.107.2022.12.09.01.44.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2022 01:44:49 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, Paolo Valente , Damien Le Moal Subject: [PATCH V10 2/8] block, bfq: forbid stable merging of queues associated with different actuators Date: Fri, 9 Dec 2022 10:44:36 +0100 Message-Id: <20221209094442.36896-3-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221209094442.36896-1-paolo.valente@linaro.org> References: <20221209094442.36896-1-paolo.valente@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org If queues associated with different actuators are merged, then control is lost on each actuator. Therefore some actuator may be underutilized, and throughput may decrease. This problem cannot occur with basic queue merging, because the latter is triggered by spatial locality, and sectors for different actuators are not close to each other. Yet it may happen with stable merging. To address this issue, this commit prevents stable merging from occurring among queues associated with different actuators. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 16dbf52ce74b..456b5f5c24fd 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5708,9 +5708,13 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge(struct bfq_data *bfqd, * it has been set already, but too long ago, then move it * forward to bfqq. Finally, move also if bfqq belongs to a * different group than last_bfqq_created, or if bfqq has a - * different ioprio or ioprio_class. If none of these - * conditions holds true, then try an early stable merge or - * schedule a delayed stable merge. + * different ioprio, ioprio_class or actuator_idx. If none of + * these conditions holds true, then try an early stable merge + * or schedule a delayed stable merge. As for the condition on + * actuator_idx, the reason is that, if queues associated with + * different actuators are merged, then control is lost on + * each actuator. Therefore some actuator may be + * underutilized, and throughput may decrease. * * A delayed merge is scheduled (instead of performing an * early merge), in case bfqq might soon prove to be more @@ -5728,7 +5732,8 @@ static struct bfq_queue *bfq_do_or_sched_stable_merge(struct bfq_data *bfqd, bfqq->creation_time) || bfqq->entity.parent != last_bfqq_created->entity.parent || bfqq->ioprio != last_bfqq_created->ioprio || - bfqq->ioprio_class != last_bfqq_created->ioprio_class) + bfqq->ioprio_class != last_bfqq_created->ioprio_class || + bfqq->actuator_idx != last_bfqq_created->actuator_idx) *source_bfqq = bfqq; else if (time_after_eq(last_bfqq_created->creation_time + bfqd->bfq_burst_interval,