From patchwork Thu Dec 29 20:37:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 13083817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A6E7C3DA79 for ; Thu, 29 Dec 2022 20:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233706AbiL2UiL (ORCPT ); Thu, 29 Dec 2022 15:38:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234058AbiL2Uhw (ORCPT ); Thu, 29 Dec 2022 15:37:52 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2021A167F7 for ; Thu, 29 Dec 2022 12:37:51 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id kw15so47328026ejc.10 for ; Thu, 29 Dec 2022 12:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9zlPY0Un+v49wAp4Agod/FVz6SE5LhUB8HuWcFquXnc=; b=sdpJY2+NyUmLkfu+69Bgwa7d+tcwQGa4x1nj/LQ5dFbmRDTboBYdKioPr/sVUeIltu BnYk3KOvv6XfK9pMHkcsWdKAFwrS16GabcsrkUj++Os0adepdMfqThdiWJq+5j2G6p4p r7lEaCONi81KIIQAYX6QfVrMQp2NUQuKjpON+wA7Gco1Xj2/wSwzpE2IGm1zndSlI54U QAMofPprAxaBIE5Ei0ccCoinDXYE/w9FbQXsVrYNXUsr9mt6mfEctD5x9sb1XWAH1sbd ij1ROss27WN+HRInA3raMHsx/RqQd/QPgh6XLSFb8mqnVNjmxXK15/NVh9yFyDN1MZHX uEwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9zlPY0Un+v49wAp4Agod/FVz6SE5LhUB8HuWcFquXnc=; b=HLL6pwOOmJQ87AWljDi3dQkDgJrzkgIWKfdkf9Ho9ivS8xvujdBZC9mDp5pSCawowH 5DI6mOjo8pPKJg1G/DYGbAN0YGjT4AAhoKAio0Gh1EkbvX6/z+rSqg8/E2ZdD6kZTNF1 8uFUvkmqV/mlmCfF5fAsFfhkqJWFgviIwma1wN/T9velNicJUqIy/jFy8cVvP09JwN/2 +VrcxkVrU9ZXuZJPwINIJL+8vHUEASNJMJmLbc1OPM5q6yA1RlTd2rxyuzooL1+NIhF/ nRPXfdXu8wkcxdO4rv7jyEwoukIkH0oFoWObqRfKw2V7xlW0YSfuAKQcunH0GPISuMBO 36Pw== X-Gm-Message-State: AFqh2kp+2hKIyaJo/mXoVI7KBb749R3OCTdk7tP1Y0OReRQWotwajlOH KgJVIiy39SK1aismpdndIC+kOg== X-Google-Smtp-Source: AMrXdXsrSlcKanVbB0wXQJjNGwoTxQZqpP3fPlRUhqCa6ENu3JN5drvPNz4/WeEsVzzsEnI35rlNiw== X-Received: by 2002:a17:906:8517:b0:7c0:a48b:2dff with SMTP id i23-20020a170906851700b007c0a48b2dffmr30315702ejx.43.1672346269647; Thu, 29 Dec 2022 12:37:49 -0800 (PST) Received: from localhost.localdomain (mob-109-118-160-216.net.vodafone.it. [109.118.160.216]) by smtp.gmail.com with ESMTPSA id d16-20020a170906371000b0073d7b876621sm8872814ejc.205.2022.12.29.12.37.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2022 12:37:49 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Davide Zini , Paolo Valente Subject: [PATCH V13 8/8] block, bfq: balance I/O injection among underutilized actuators Date: Thu, 29 Dec 2022 21:37:07 +0100 Message-Id: <20221229203707.68458-9-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221229203707.68458-1-paolo.valente@linaro.org> References: <20221229203707.68458-1-paolo.valente@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: Davide Zini Upon the invocation of its dispatch function, BFQ returns the next I/O request of the in-service bfq_queue, unless some exception holds. One such exception is that there is some underutilized actuator, different from the actuator for which the in-service queue contains I/O, and that some other bfq_queue happens to contain I/O for such an actuator. In this case, the next I/O request of the latter bfq_queue, and not of the in-service bfq_queue, is returned (I/O is injected from that bfq_queue). To find such an actuator, a linear scan, in increasing index order, is performed among actuators. Performing a linear scan entails a prioritization among actuators: an underutilized actuator may be considered for injection only if all actuators with a lower index are currently fully utilized, or if there is no pending I/O for any lower-index actuator that happens to be underutilized. This commits breaks this prioritization and tends to distribute injection uniformly across actuators. This is obtained by adding the following condition to the linear scan: even if an actuator A is underutilized, A is however skipped if its load is higher than that of the next actuator. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente Signed-off-by: Davide Zini --- block/bfq-iosched.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 6ebcd94bf3b3..f729f51fd383 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4767,10 +4767,16 @@ bfq_find_active_bfqq_for_actuator(struct bfq_data *bfqd, int idx) /* * Perform a linear scan of each actuator, until an actuator is found - * for which the following two conditions hold: the load of the - * actuator is below the threshold (see comments on actuator_load_threshold - * for details), and there is a queue that contains I/O for that - * actuator. On success, return that queue. + * for which the following three conditions hold: the load of the + * actuator is below the threshold (see comments on + * actuator_load_threshold for details) and lower than that of the + * next actuator (comments on this extra condition below), and there + * is a queue that contains I/O for that actuator. On success, return + * that queue. + * + * Performing a plain linear scan entails a prioritization among + * actuators. The extra condition above breaks this prioritization and + * tends to distribute injection uniformly across actuators. */ static struct bfq_queue * bfq_find_bfqq_for_underused_actuator(struct bfq_data *bfqd) @@ -4778,7 +4784,9 @@ bfq_find_bfqq_for_underused_actuator(struct bfq_data *bfqd) int i; for (i = 0 ; i < bfqd->num_actuators; i++) { - if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold) { + if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold && + (i == bfqd->num_actuators - 1 || + bfqd->rq_in_driver[i] < bfqd->rq_in_driver[i+1])) { struct bfq_queue *bfqq = bfq_find_active_bfqq_for_actuator(bfqd, i);