From patchwork Tue Jan 3 14:55:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 13087554 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A649FC54EBC for ; Tue, 3 Jan 2023 14:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238016AbjACOz7 (ORCPT ); Tue, 3 Jan 2023 09:55:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238029AbjACOzq (ORCPT ); Tue, 3 Jan 2023 09:55:46 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8DEB120A0 for ; Tue, 3 Jan 2023 06:55:34 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id u19so74245600ejm.8 for ; Tue, 03 Jan 2023 06:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UgmkxpqJyM32/nscplImRhu54DAKw5l22AaUH8QIVjM=; b=tL2ZtKvOKr8GsSiNzT6HtvXKQzHNy5yXMQchI6xlaOeKOY4LzuvukcFfCFrhSjgsgr qFELHhcsGdq8qqIDyAY48SWFHlpNwvCs0bE/87KGS99zNAUD6yhzuiMcjUaNe35jJnfF 9nYBCkh4GoDV0ZjGmrqoeRbmDCRzH3riaXBQa66FcgeQ1Zp1Cx2wbcnuNZDvs4Z7byyz fcxMlJEfQdgZnLCRK+g3jJy9KO2MwPP2ateNFqqAS7uS76Ol1jxVlNUte34T+07Ox0be I3txtr9ikkxUwgfOHXUnfIXCS4r/gLyZFSCPnbSN5F1YkGOwkERNHFxz5/D19LIIbKvN d0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UgmkxpqJyM32/nscplImRhu54DAKw5l22AaUH8QIVjM=; b=gmQnPMjDHc5mu8UVb9MwYtozrSGRNifWW7lnlkgNKB+32Y54PNmhHH8rCx8JRt8XYQ sJp9fV4Tz1/HgZAiq+GnwYZxzatsgYm0wtwGaJuuIMG5IcWcy3fO/XDi8Y9NZYOXUGD3 HTHL7/3VqxX+IIY84qvWCBeNg2pvz7zZMv5We02uhPRqF/uxMH6w1V+a/F+ONxL5gBHX SRks39djaLowjFGo2imWhLJ6wl7EEyI+F+OJbEAAjWpXDusxGoTIq84HGS4VWjkMQmEY rzt0uHDUpQNxgLD4dCUpPhS+DZmv7d3sEIH+qBToKKAgALDPtV/7Qm/koj7K4Rv0RrJM nzcA== X-Gm-Message-State: AFqh2kqzOWfEAojjIKAs78kckQB9MBPNlF1g8hGhnnCqyfuwkIFEJwTR 2tyisy5UoF959dx4Gihxnlx9uZXIW7P2gmOD X-Google-Smtp-Source: AMrXdXthqpuEe63lXh45UrIXw1Pm+fDkSr40eSGLWJI3kokdasjArLGSfqNYUTQjHK0cWva36m/e7Q== X-Received: by 2002:a17:906:430a:b0:7c1:54b9:c688 with SMTP id j10-20020a170906430a00b007c154b9c688mr37090174ejm.60.1672757734461; Tue, 03 Jan 2023 06:55:34 -0800 (PST) Received: from localhost.localdomain (mob-5-91-46-2.net.vodafone.it. [5.91.46.2]) by smtp.gmail.com with ESMTPSA id g17-20020a17090604d100b007c16fdc93ddsm14122595eja.81.2023.01.03.06.55.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2023 06:55:34 -0800 (PST) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, arie.vanderhoeven@seagate.com, rory.c.chen@seagate.com, glen.valante@linaro.org, damien.lemoal@opensource.wdc.com, Davide Zini , Paolo Valente Subject: [PATCH V13 REBASED 8/8] block, bfq: balance I/O injection among underutilized actuators Date: Tue, 3 Jan 2023 15:55:03 +0100 Message-Id: <20230103145503.71712-9-paolo.valente@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230103145503.71712-1-paolo.valente@linaro.org> References: <20230103145503.71712-1-paolo.valente@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: Davide Zini Upon the invocation of its dispatch function, BFQ returns the next I/O request of the in-service bfq_queue, unless some exception holds. One such exception is that there is some underutilized actuator, different from the actuator for which the in-service queue contains I/O, and that some other bfq_queue happens to contain I/O for such an actuator. In this case, the next I/O request of the latter bfq_queue, and not of the in-service bfq_queue, is returned (I/O is injected from that bfq_queue). To find such an actuator, a linear scan, in increasing index order, is performed among actuators. Performing a linear scan entails a prioritization among actuators: an underutilized actuator may be considered for injection only if all actuators with a lower index are currently fully utilized, or if there is no pending I/O for any lower-index actuator that happens to be underutilized. This commits breaks this prioritization and tends to distribute injection uniformly across actuators. This is obtained by adding the following condition to the linear scan: even if an actuator A is underutilized, A is however skipped if its load is higher than that of the next actuator. Reviewed-by: Damien Le Moal Signed-off-by: Paolo Valente Signed-off-by: Davide Zini --- block/bfq-iosched.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index d42a229b5a86..815b884d6c5a 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4767,10 +4767,16 @@ bfq_find_active_bfqq_for_actuator(struct bfq_data *bfqd, int idx) /* * Perform a linear scan of each actuator, until an actuator is found - * for which the following two conditions hold: the load of the - * actuator is below the threshold (see comments on actuator_load_threshold - * for details), and there is a queue that contains I/O for that - * actuator. On success, return that queue. + * for which the following three conditions hold: the load of the + * actuator is below the threshold (see comments on + * actuator_load_threshold for details) and lower than that of the + * next actuator (comments on this extra condition below), and there + * is a queue that contains I/O for that actuator. On success, return + * that queue. + * + * Performing a plain linear scan entails a prioritization among + * actuators. The extra condition above breaks this prioritization and + * tends to distribute injection uniformly across actuators. */ static struct bfq_queue * bfq_find_bfqq_for_underused_actuator(struct bfq_data *bfqd) @@ -4778,7 +4784,9 @@ bfq_find_bfqq_for_underused_actuator(struct bfq_data *bfqd) int i; for (i = 0 ; i < bfqd->num_actuators; i++) { - if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold) { + if (bfqd->rq_in_driver[i] < bfqd->actuator_load_threshold && + (i == bfqd->num_actuators - 1 || + bfqd->rq_in_driver[i] < bfqd->rq_in_driver[i+1])) { struct bfq_queue *bfqq = bfq_find_active_bfqq_for_actuator(bfqd, i);