From patchwork Tue Jan 10 13:27:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 13095144 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BE3C46467 for ; Tue, 10 Jan 2023 13:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233075AbjAJN1f (ORCPT ); Tue, 10 Jan 2023 08:27:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233904AbjAJN1X (ORCPT ); Tue, 10 Jan 2023 08:27:23 -0500 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7015D3B3 for ; Tue, 10 Jan 2023 05:27:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1673357242; x=1704893242; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R2Z83dzCeZHKddXeuTUmcn0ovi37DfKGzvD49wy2LNI=; b=SE6/89SB6PPSiD99VzaMbySH0LXi7Li7OP3fly1xv48zwBfhT6GMAOhi JvVx/cCULz1EA198kLx8mRRzEtRbafVVAJ4y5oP7yyxUtfZ++BlznyzeB 4Rnz5rI2kpkFw1ELOFAUng1HA6yQnfo/FsDIV1FVnekIaRxj8TRFUV1rR Aph05/Nuk8AEhw2VqxLUKr3fmnBdJs4pBPQeAIKE0xXvPbFxlOHvFJRtE p2Mdi8KBnyPwUNCT3fv49tY/wDNZi89Gjkg65o3OirRxhzusWDJIP+Eqe wPsCWA0myXyVgW7gaYPMtSQ05LPqyoIDOvwiT9GEdVvzkXEGFxgipI65r A==; X-IronPort-AV: E=Sophos;i="5.96,315,1665417600"; d="scan'208";a="324741511" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 10 Jan 2023 21:27:20 +0800 IronPort-SDR: Q7kL7U8dA4sbh7ys3xL+C1ctsy+6zY0kxIvyXeA4YMTepr6++K1hUeJxHb9+trQzzAH/edXXJa 21mSolCVoWVmk6+p2F7AQv/9Lp+Tw56ONMJ7nDGv3GFzt3Cjj0mV1eH3pmv+AHGM/0NHIjMUeF WD9Z2m2/FiGcSBX2Z1Jgxa+4/tRhax5dkgUmr5QqQA705cT22pYQbTjF6tpCOSHFZWYcTej9qc 2UwFsx5aqYqXVypJ66FyQMOk75b0H8V5OsTcXt1X4wF9udBkEAWrZhkaC7ebKXjkQFL+g8vQNw ARM= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Jan 2023 04:39:26 -0800 IronPort-SDR: EfmPRZtYNT0V+qIyJJXf3fesxRR6uwNYZkhD3nDaQgudxEtiBoFMe2jI3d7g3SVAqF9xgg97Bw K9yRTBpdhl/8HMH4sm81eeTrTFnypGDXcVDRYOLEz9vSzN9PKFVOszWlgbEbnmc3jZJStFKJJj aWPEf1sRuGkt+K9JIROlbrjxsd49+QYZWswWW01iLdLsaYvXzg7063Q4dZ/n9RDSClOj/XbAc3 iNxuyK2dfW+obK8e6LghYD1Xh5CummkHeGPQH3ERHIzbLIxds1Fn+NsD8OvbS7Pwa1H9N6ogwd 0gY= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 10 Jan 2023 05:27:21 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Nrs6w5tkqz1Rwrq for ; Tue, 10 Jan 2023 05:27:20 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:mime-version :references:in-reply-to:x-mailer:message-id:date:subject:to :from; s=dkim; t=1673357240; x=1675949241; bh=R2Z83dzCeZHKddXeuT Umcn0ovi37DfKGzvD49wy2LNI=; b=ZJ+0O30axYCJ+x2trR1XYoFhrpq/aV2ttv jKGDDhHgt9mHLxqEY5YPGnVjkbC3LIVJ9aTJQ3QZW5db72btJvoJv3RlGoaxKyD0 uQfoQbv3rErZBsD3qjMbzTVqXhM9hILOMskdDAx+O9WJVQ2+CVqo6PIm8HV5etWp Ah0SJ68XAR49yjj2TSHdIwVAaLJYbi/XpIvqTbUKhYX7wgUd4BrCMeMxUrBzJCZN +FPP/1/B5Q5vQA5/tsTsd7liprMPNowc0/UERrSScnLjYdSlkOx36yo6GHKtQ147 wDZMT3dh4I3QY0BmRyQfwkpCXOO2/uV2m0pX0S/bnYahnfY3ezxg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oF99lCA6hGml for ; Tue, 10 Jan 2023 05:27:20 -0800 (PST) Received: from washi.fujisawa.hgst.com (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Nrs6v2jnwz1RvLy; Tue, 10 Jan 2023 05:27:19 -0800 (PST) From: Damien Le Moal To: linux-ide@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe Cc: "Maciej S . Szmigiero" , Christoph Hellwig Subject: [PATCH v9 6/6] ata: libata: blacklist FUA support for known buggy drives Date: Tue, 10 Jan 2023 22:27:10 +0900 Message-Id: <20230110132710.252015-7-damien.lemoal@opensource.wdc.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110132710.252015-1-damien.lemoal@opensource.wdc.com> References: <20230110132710.252015-1-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Thread [1] reported back in 2012 problems with enabling FUA for 3 different drives. Add these drives to ata_device_blacklist[] to mark them with the ATA_HORKAGE_NO_FUA flag. To be conservative and avoid problems on old systems, the model number for the three new entries are defined as to widely match all drives in the same product line. [1]: https://lore.kernel.org/lkml/CA+6av4=uxu_q5U_46HtpUt=FSgbh3pZuAEY54J5_xK=MKWq-YQ@mail.gmail.com/ Suggested-by: Maciej S. Szmigiero Signed-off-by: Damien Le Moal Reviewed-by: Hannes Reinecke Reviewed-by: Maciej S. Szmigiero Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn Reviewed-by: Niklas Cassel --- drivers/ata/libata-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index ac88376f095a..36c1aca310e9 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4133,6 +4133,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { /* Buggy FUA */ { "Maxtor", "BANC1G10", ATA_HORKAGE_NO_FUA }, + { "WDC*WD2500J*", NULL, ATA_HORKAGE_NO_FUA }, + { "OCZ-VERTEX*", NULL, ATA_HORKAGE_NO_FUA }, + { "INTEL*SSDSC2CT*", NULL, ATA_HORKAGE_NO_FUA }, /* End Marker */ { }