| Message ID | 20230131085220.1038241-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memstick: core: Imply IOSCHED_BFQ | expand |
On 1/31/23 00:52, Linus Walleij wrote: > If we enable the memory stick block layer, use Kconfig to imply > the BFQ I/O scheduler. > > As all memstick devices are single-queue, this is the scheduler that > users want so let's be helpful and make sure it gets > default-selected into a manual kernel configuration. It will still > need to be enabled at runtime (usually with udev scripts). Do users really want the BFQ scheduler? Has performance of BFQ been compared with iocost (CONFIG_BLK_CGROUP_IOCOST)? My colleagues are using iocost instead of BFQ in resource-constrained environments. Bart.
On Tue, 31 Jan 2023 at 09:52, Linus Walleij <linus.walleij@linaro.org> wrote: > > If we enable the memory stick block layer, use Kconfig to imply > the BFQ I/O scheduler. > > As all memstick devices are single-queue, this is the scheduler that > users want so let's be helpful and make sure it gets > default-selected into a manual kernel configuration. It will still > need to be enabled at runtime (usually with udev scripts). > > Cc: linux-block@vger.kernel.org > Cc: Paolo Valente <paolo.valente@linaro.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> For the similar reasons to why I applied the MMC patch, applied for next, thanks! Kind regards Uffe > --- > drivers/memstick/core/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/memstick/core/Kconfig b/drivers/memstick/core/Kconfig > index 08192fd70eb4..50fa0711da9d 100644 > --- a/drivers/memstick/core/Kconfig > +++ b/drivers/memstick/core/Kconfig > @@ -20,6 +20,7 @@ config MEMSTICK_UNSAFE_RESUME > config MSPRO_BLOCK > tristate "MemoryStick Pro block device driver" > depends on BLOCK > + imply IOSCHED_BFQ > help > Say Y here to enable the MemoryStick Pro block device driver > support. This provides a block device driver, which you can use > @@ -29,6 +30,7 @@ config MSPRO_BLOCK > config MS_BLOCK > tristate "MemoryStick Standard device driver" > depends on BLOCK > + imply IOSCHED_BFQ > help > Say Y here to enable the MemoryStick Standard device driver > support. This provides a block device driver, which you can use > -- > 2.34.1 >
On 2/2/23 8:22 AM, Ulf Hansson wrote: > On Tue, 31 Jan 2023 at 09:52, Linus Walleij <linus.walleij@linaro.org> wrote: >> >> If we enable the memory stick block layer, use Kconfig to imply >> the BFQ I/O scheduler. >> >> As all memstick devices are single-queue, this is the scheduler that >> users want so let's be helpful and make sure it gets >> default-selected into a manual kernel configuration. It will still >> need to be enabled at runtime (usually with udev scripts). >> >> Cc: linux-block@vger.kernel.org >> Cc: Paolo Valente <paolo.valente@linaro.org> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > For the similar reasons to why I applied the MMC patch, applied for > next, thanks! And a bad idea, for the exact same reasons...
diff --git a/drivers/memstick/core/Kconfig b/drivers/memstick/core/Kconfig index 08192fd70eb4..50fa0711da9d 100644 --- a/drivers/memstick/core/Kconfig +++ b/drivers/memstick/core/Kconfig @@ -20,6 +20,7 @@ config MEMSTICK_UNSAFE_RESUME config MSPRO_BLOCK tristate "MemoryStick Pro block device driver" depends on BLOCK + imply IOSCHED_BFQ help Say Y here to enable the MemoryStick Pro block device driver support. This provides a block device driver, which you can use @@ -29,6 +30,7 @@ config MSPRO_BLOCK config MS_BLOCK tristate "MemoryStick Standard device driver" depends on BLOCK + imply IOSCHED_BFQ help Say Y here to enable the MemoryStick Standard device driver support. This provides a block device driver, which you can use
If we enable the memory stick block layer, use Kconfig to imply the BFQ I/O scheduler. As all memstick devices are single-queue, this is the scheduler that users want so let's be helpful and make sure it gets default-selected into a manual kernel configuration. It will still need to be enabled at runtime (usually with udev scripts). Cc: linux-block@vger.kernel.org Cc: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/memstick/core/Kconfig | 2 ++ 1 file changed, 2 insertions(+)